Add MercureBundle recipe #477
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
dunglas
commented
Oct 26, 2018
dunglas
commented
| Q | A |
|---|---|
| License | MIT |
ghost
suggested changes
Oct 26, 2018
ghost
suggested changes
Oct 26, 2018
ghost
suggested changes
Oct 26, 2018
ghost
deployed
to
Pierstoval
reviewed
Oct 26, 2018
| "config/": "%CONFIG_DIR%/" | ||
| }, | ||
| "container": { | ||
| "env(MERCURE_PUBLISH_URL)": "", |
There was a problem hiding this comment.
Why add them as defaults in the container when you have them set up in env? 🤔
There was a problem hiding this comment.
To prevent an error when env var are not defined (when building a Docker container for instance).
There was a problem hiding this comment.
You can instead define the env(MERCURE_PUBLISH_URL) parameter in the bundle.
There was a problem hiding this comment.
It’s not the bundle’s responsibility: you may use it without env vars.
Also, the user may choose to use other names of env vars.
maxhelias
approved these changes
Oct 26, 2018
chalasr
approved these changes
Oct 28, 2018
nicolas-grekas
approved these changes
Nov 30, 2018
ghost
pushed a commit
that referenced
this pull request
Nov 30, 2018
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.