Optimize perf by replacing call_user_func with dynamic vars

ostrolucky · ostrolucky · commit 7c808e690f90 · 2018-12-09T23:58:21.000+01:00
diff --git a/Loader/ObjectRouteLoader.php b/Loader/ObjectRouteLoader.php
@@ -67,7 +67,7 @@ public function load($resource, $type = null)
             throw new \BadMethodCallException(sprintf('Method "%s" not found on "%s" when importing routing resource "%s"', $method, \get_class($loaderObject), $resource));
         }
 
-        $routeCollection = \call_user_func(array($loaderObject, $method), $this);
+        $routeCollection = $loaderObject->$method($this);
 
         if (!$routeCollection instanceof RouteCollection) {
             $type = \is_object($routeCollection) ? \get_class($routeCollection) : \gettype($routeCollection);

Original file line number	Diff line number	Diff line change
`@@ -67,7 +67,7 @@ public function load($resource, $type = null)`
`67`	`67`	`throw new \BadMethodCallException(sprintf('Method "%s" not found on "%s" when importing routing resource "%s"', $method, \get_class($loaderObject), $resource));`
`68`	`68`	`}`
`69`	`69`
`70`		`- $routeCollection = \call_user_func(array($loaderObject, $method), $this);`
	`70`	`+ $routeCollection = $loaderObject->$method($this);`
`71`	`71`
`72`	`72`	`if (!$routeCollection instanceof RouteCollection) {`
`73`	`73`	`$type = \is_object($routeCollection) ? \get_class($routeCollection) : \gettype($routeCollection);`