Deprecate configuring tag names and service ids in compiler passes

nicolas-grekas · nicolas-grekas · commit 8253a8c266d9 · 2021-03-15T19:33:21.000+01:00
diff --git a/DependencyInjection/RoutingResolverPass.php b/DependencyInjection/RoutingResolverPass.php
@@ -30,6 +30,10 @@ class RoutingResolverPass implements CompilerPassInterface
 
     public function __construct(string $resolverServiceId = 'routing.resolver', string $loaderTag = 'routing.loader')
     {
+        if (0 < \func_num_args()) {
+            trigger_deprecation('symfony/routing', '5.3', 'Configuring "%s" is deprecated.', __CLASS__);
+        }
+
         $this->resolverServiceId = $resolverServiceId;
         $this->loaderTag = $loaderTag;
     }

Original file line number	Diff line number	Diff line change
`@@ -30,6 +30,10 @@ class RoutingResolverPass implements CompilerPassInterface`
`30`	`30`
`31`	`31`	`public function __construct(string $resolverServiceId = 'routing.resolver', string $loaderTag = 'routing.loader')`
`32`	`32`	`{`
	`33`	`+ if (0 < \func_num_args()) {`
	`34`	`+ trigger_deprecation('symfony/routing', '5.3', 'Configuring "%s" is deprecated.', __CLASS__);`
	`35`	`+ }`
	`36`	`+`
`33`	`37`	`$this->resolverServiceId = $resolverServiceId;`
`34`	`38`	`$this->loaderTag = $loaderTag;`
`35`	`39`	`}`