minor #42490 More return type fixes (bis) (nicolas-grekas)

nicolas-grekas · nicolas-grekas · commit 8b23d3d4104e · 2021-08-12T15:55:08.000+02:00
This PR was merged into the 5.4 branch.

Discussion
----------

More return type fixes (bis)

| Q             | A
| ------------- | ---
| Branch?       | 5.4
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       | -
| License       | MIT
| Doc PR        | -

Commits
-------

c6a20b4e4d More return type fixes (bis)
diff --git a/Matcher/ExpressionLanguageProvider.php b/Matcher/ExpressionLanguageProvider.php
@@ -34,8 +34,10 @@ public function __construct(ServiceProviderInterface $functions)
      */
     public function getFunctions()
     {
+        $functions = [];
+
         foreach ($this->functions->getProvidedServices() as $function => $type) {
-            yield new ExpressionFunction(
+            $functions[] = new ExpressionFunction(
                 $function,
                 static function (...$args) use ($function) {
                     return sprintf('($context->getParameter(\'_functions\')->get(%s)(%s))', var_export($function, true), implode(', ', $args));
@@ -45,6 +47,8 @@ function ($values, ...$args) use ($function) {
                 }
             );
         }
+
+        return $functions;
     }
 
     public function get(string $function): callable

Original file line number	Diff line number	Diff line change
`@@ -34,8 +34,10 @@ public function __construct(ServiceProviderInterface $functions)`
`34`	`34`	`*/`
`35`	`35`	`public function getFunctions()`
`36`	`36`	`{`
	`37`	`+ $functions = [];`
	`38`	`+`
`37`	`39`	`foreach ($this->functions->getProvidedServices() as $function => $type) {`
`38`		`- yield new ExpressionFunction(`
	`40`	`+ $functions[] = new ExpressionFunction(`
`39`	`41`	`$function,`
`40`	`42`	`static function (...$args) use ($function) {`
`41`	`43`	`return sprintf('($context->getParameter(\'_functions\')->get(%s)(%s))', var_export($function, true), implode(', ', $args));`
`@@ -45,6 +47,8 @@ function ($values, ...$args) use ($function) {`
`45`	`47`	`}`
`46`	`48`	`);`
`47`	`49`	`}`
	`50`	`+`
	`51`	`+ return $functions;`
`48`	`52`	`}`
`49`	`53`
`50`	`54`	`public function get(string $function): callable`