Fixed Symfony 4.3 deprecated messages

Author: XWB

Domain/SecurityIdentityRetrievalStrategy.php

@@ -15,6 +15,7 @@
 use Symfony\Component\Security\Core\Authentication\Token\AnonymousToken;
 use Symfony\Component\Security\Core\Authentication\Token\TokenInterface;
 use Symfony\Component\Security\Acl\Model\SecurityIdentityRetrievalStrategyInterface;
+use Symfony\Component\Security\Core\Role\Role;
 use Symfony\Component\Security\Core\Role\RoleHierarchyInterface;
 use Symfony\Component\Security\Core\Authorization\Voter\AuthenticatedVoter;
 
@@ -57,8 +58,16 @@ public function getSecurityIdentities(TokenInterface $token)
         }
 
         // add all reachable roles
-        foreach ($this->roleHierarchy->getReachableRoles($token->getRoles()) as $role) {
-            $sids[] = new RoleSecurityIdentity($role);
+        $roles = $this->getRoleNames($token);
+        if (method_exists($this->roleHierarchy, 'getReachableRoleNames')) {
+            foreach ($this->roleHierarchy->getReachableRoleNames($roles) as $role) {
+                $sids[] = new RoleSecurityIdentity($role);
+            }
+        } else {
+            // Symfony < 4.3 BC layer
+            foreach ($this->roleHierarchy->getReachableRoles($roles) as $role) {
+                $sids[] = new RoleSecurityIdentity($role);
+            }
         }
 
         // add built-in special roles
@@ -75,4 +84,16 @@ public function getSecurityIdentities(TokenInterface $token)
 
         return $sids;
     }
+
+    private function getRoleNames(TokenInterface $token): array
+    {
+        if (method_exists($token, 'getRoleNames')) {
+            return $token->getRoleNames();
+        }
+
+        // Symfony < 4.3 BC layer
+        return array_map(function (Role $role) {
+            return $role->getRole();
+        }, $token->getRoles());
+    }
 }

Tests/Domain/SecurityIdentityRetrievalStrategyTest.php

@@ -38,11 +38,21 @@ public function testGetSecurityIdentities($user, array $roles, $authenticationSt
                         ->setMockClassName($class)
                         ->getMock();
         }
-        $token
-            ->expects($this->once())
-            ->method('getRoles')
-            ->will($this->returnValue(array('foo')))
-        ;
+
+        if (method_exists($token, 'getRoleNames')) {
+            $token
+                ->expects($this->once())
+                ->method('getRoleNames')
+                ->will($this->returnValue(array('foo')))
+            ;
+        } else {
+            $token
+                ->expects($this->once())
+                ->method('getRoles')
+                ->will($this->returnValue(array('foo')))
+            ;
+        }
+
         if ('anonymous' === $authenticationStatus) {
             $token
                 ->expects($this->never())