fix some risky tests

Author: xabbuh

Tests/Encoder/BCryptPasswordEncoderTest.php

@@ -39,11 +39,20 @@ public function testCostAboveRange()
         new BCryptPasswordEncoder(32);
     }
 
-    public function testCostInRange()
+    /**
+     * @dataProvider validRangeData
+     */
+    public function testCostInRange($cost)
+    {
+        $this->assertInstanceOf('Symfony\Component\Security\Core\Encoder\BCryptPasswordEncoder', new BCryptPasswordEncoder($cost));
+    }
+
+    public function validRangeData()
     {
-        for ($cost = 4; $cost <= 31; ++$cost) {
-            new BCryptPasswordEncoder($cost);
-        }
+        $costs = range(4, 31);
+        array_walk($costs, function (&$cost) { $cost = array($cost); });
+
+        return $costs;
     }
 
     public function testResultLength()

Tests/LegacySecurityContextTest.php

@@ -86,7 +86,8 @@ public function testOldConstructorSignature()
     {
         $authenticationManager = $this->getMockBuilder('Symfony\Component\Security\Core\Authentication\AuthenticationManagerInterface')->getMock();
         $accessDecisionManager = $this->getMockBuilder('Symfony\Component\Security\Core\Authorization\AccessDecisionManagerInterface')->getMock();
-        new SecurityContext($authenticationManager, $accessDecisionManager);
+
+        $this->assertInstanceOf('Symfony\Component\Security\Core\SecurityContext', new SecurityContext($authenticationManager, $accessDecisionManager));
     }
 
     /**