Merge branch '2.4'

* 2.4:
  fixed various inconsistencies
  reduced recursion when building DumperPrefixCollection
  renamed variables - making next change more readable
  removing dead code.
  [ExpressionLanguage] added some tests for the built-in constant() function
  [ExpressionLanguage] added some documentation about functions
  [DomCrawler] Fixed filterXPath() chaining
  [DomCrawler] Fixed incorrect handling of image inputs

Author: fabpot

Tests/Authentication/Provider/DaoAuthenticationProviderTest.php

@@ -115,7 +115,7 @@ public function testCheckAuthenticationWhenCredentialsAreEmpty()
             ->method('isPasswordValid')
         ;
 
-        $provider = $this->getProvider(false, false, $encoder);
+        $provider = $this->getProvider(null, null, $encoder);
         $method = new \ReflectionMethod($provider, 'checkAuthentication');
         $method->setAccessible(true);
 
@@ -142,7 +142,7 @@ public function testCheckAuthenticationWhenCredentialsAre0()
             ->will($this->returnValue(true))
         ;
 
-        $provider = $this->getProvider(false, false, $encoder);
+        $provider = $this->getProvider(null, null, $encoder);
         $method = new \ReflectionMethod($provider, 'checkAuthentication');
         $method->setAccessible(true);
 
@@ -171,7 +171,7 @@ public function testCheckAuthenticationWhenCredentialsAreNotValid()
                 ->will($this->returnValue(false))
         ;
 
-        $provider = $this->getProvider(false, false, $encoder);
+        $provider = $this->getProvider(null, null, $encoder);
         $method = new \ReflectionMethod($provider, 'checkAuthentication');
         $method->setAccessible(true);
 
@@ -206,7 +206,7 @@ public function testCheckAuthenticationDoesNotReauthenticateWhenPasswordHasChang
                ->will($this->returnValue('newFoo'))
         ;
 
-        $provider = $this->getProvider(false, false, null);
+        $provider = $this->getProvider();
         $reflection = new \ReflectionMethod($provider, 'checkAuthentication');
         $reflection->setAccessible(true);
         $reflection->invoke($provider, $dbUser, $token);
@@ -231,7 +231,7 @@ public function testCheckAuthenticationWhenTokenNeedsReauthenticationWorksWithou
                ->will($this->returnValue('foo'))
         ;
 
-        $provider = $this->getProvider(false, false, null);
+        $provider = $this->getProvider();
         $reflection = new \ReflectionMethod($provider, 'checkAuthentication');
         $reflection->setAccessible(true);
         $reflection->invoke($provider, $dbUser, $token);
@@ -245,7 +245,7 @@ public function testCheckAuthentication()
                 ->will($this->returnValue(true))
         ;
 
-        $provider = $this->getProvider(false, false, $encoder);
+        $provider = $this->getProvider(null, null, $encoder);
         $method = new \ReflectionMethod($provider, 'checkAuthentication');
         $method->setAccessible(true);
 
@@ -270,17 +270,17 @@ protected function getSupportedToken()
         return $mock;
     }
 
-    protected function getProvider($user = false, $userChecker = false, $passwordEncoder = null)
+    protected function getProvider($user = null, $userChecker = null, $passwordEncoder = null)
     {
         $userProvider = $this->getMock('Symfony\\Component\\Security\\Core\\User\\UserProviderInterface');
-        if (false !== $user) {
+        if (null !== $user) {
             $userProvider->expects($this->once())
                          ->method('loadUserByUsername')
                          ->will($this->returnValue($user))
             ;
         }
 
-        if (false === $userChecker) {
+        if (null === $userChecker) {
             $userChecker = $this->getMock('Symfony\\Component\\Security\\Core\\User\\UserCheckerInterface');
         }
 

Tests/Authentication/Provider/PreAuthenticatedAuthenticationProviderTest.php

@@ -114,17 +114,17 @@ protected function getSupportedToken($user = false, $credentials = false)
         return $token;
     }
 
-    protected function getProvider($user = false, $userChecker = false)
+    protected function getProvider($user = null, $userChecker = null)
     {
         $userProvider = $this->getMock('Symfony\Component\Security\Core\User\UserProviderInterface');
-        if (false !== $user) {
+        if (null !== $user) {
             $userProvider->expects($this->once())
                          ->method('loadUserByUsername')
                          ->will($this->returnValue($user))
             ;
         }
 
-        if (false === $userChecker) {
+        if (null === $userChecker) {
             $userChecker = $this->getMock('Symfony\Component\Security\Core\User\UserCheckerInterface');
         }
 

Tests/Util/SecureRandomTest.php

@@ -111,8 +111,8 @@ public function testLongRun($secureRandom)
     {
         $b = $this->getBitSequence($secureRandom, 20000);
 
-        $longestRun = 0;
-        $currentRun = $lastBit = null;
+        $longestRun = $currentRun = 0;
+        $lastBit = null;
         for ($i = 0; $i < 20000; $i++) {
             if ($lastBit === $b[$i]) {
                 $currentRun += 1;