[Tests] Migrate tests to static data providers

Author: alexandre-daubois

Tests/Authorization/Strategy/AffirmativeStrategyTest.php

@@ -20,13 +20,13 @@ public function provideStrategyTests(): iterable
     {
         $strategy = new AffirmativeStrategy();
 
-        yield [$strategy, static::getVoters(1, 0, 0), true];
-        yield [$strategy, static::getVoters(1, 2, 0), true];
-        yield [$strategy, static::getVoters(0, 1, 0), false];
-        yield [$strategy, static::getVoters(0, 0, 1), false];
+        yield [$strategy, self::getVoters(1, 0, 0), true];
+        yield [$strategy, self::getVoters(1, 2, 0), true];
+        yield [$strategy, self::getVoters(0, 1, 0), false];
+        yield [$strategy, self::getVoters(0, 0, 1), false];
 
         $strategy = new AffirmativeStrategy(true);
 
-        yield [$strategy, static::getVoters(0, 0, 1), true];
+        yield [$strategy, self::getVoters(0, 0, 1), true];
     }
 }

Tests/Authorization/Strategy/ConsensusStrategyTest.php

@@ -20,21 +20,21 @@ public function provideStrategyTests(): iterable
     {
         $strategy = new ConsensusStrategy();
 
-        yield [$strategy, static::getVoters(1, 0, 0), true];
-        yield [$strategy, static::getVoters(1, 2, 0), false];
-        yield [$strategy, static::getVoters(2, 1, 0), true];
-        yield [$strategy, static::getVoters(0, 0, 1), false];
+        yield [$strategy, self::getVoters(1, 0, 0), true];
+        yield [$strategy, self::getVoters(1, 2, 0), false];
+        yield [$strategy, self::getVoters(2, 1, 0), true];
+        yield [$strategy, self::getVoters(0, 0, 1), false];
 
-        yield [$strategy, static::getVoters(2, 2, 0), true];
-        yield [$strategy, static::getVoters(2, 2, 1), true];
+        yield [$strategy, self::getVoters(2, 2, 0), true];
+        yield [$strategy, self::getVoters(2, 2, 1), true];
 
         $strategy = new ConsensusStrategy(true);
 
-        yield [$strategy, static::getVoters(0, 0, 1), true];
+        yield [$strategy, self::getVoters(0, 0, 1), true];
 
         $strategy = new ConsensusStrategy(false, false);
 
-        yield [$strategy, static::getVoters(2, 2, 0), false];
-        yield [$strategy, static::getVoters(2, 2, 1), false];
+        yield [$strategy, self::getVoters(2, 2, 0), false];
+        yield [$strategy, self::getVoters(2, 2, 1), false];
     }
 }

Tests/Authorization/Strategy/PriorityStrategyTest.php

@@ -22,23 +22,23 @@ public function provideStrategyTests(): iterable
         $strategy = new PriorityStrategy();
 
         yield [$strategy, [
-            static::getVoter(VoterInterface::ACCESS_ABSTAIN),
-            static::getVoter(VoterInterface::ACCESS_GRANTED),
-            static::getVoter(VoterInterface::ACCESS_DENIED),
-            static::getVoter(VoterInterface::ACCESS_DENIED),
+            self::getVoter(VoterInterface::ACCESS_ABSTAIN),
+            self::getVoter(VoterInterface::ACCESS_GRANTED),
+            self::getVoter(VoterInterface::ACCESS_DENIED),
+            self::getVoter(VoterInterface::ACCESS_DENIED),
         ], true];
 
         yield [$strategy, [
-            static::getVoter(VoterInterface::ACCESS_ABSTAIN),
-            static::getVoter(VoterInterface::ACCESS_DENIED),
-            static::getVoter(VoterInterface::ACCESS_GRANTED),
-            static::getVoter(VoterInterface::ACCESS_GRANTED),
+            self::getVoter(VoterInterface::ACCESS_ABSTAIN),
+            self::getVoter(VoterInterface::ACCESS_DENIED),
+            self::getVoter(VoterInterface::ACCESS_GRANTED),
+            self::getVoter(VoterInterface::ACCESS_GRANTED),
         ], false];
 
-        yield [$strategy, static::getVoters(0, 0, 2), false];
+        yield [$strategy, self::getVoters(0, 0, 2), false];
 
         $strategy = new PriorityStrategy(true);
 
-        yield [$strategy, static::getVoters(0, 0, 2), true];
+        yield [$strategy, self::getVoters(0, 0, 2), true];
     }
 }

Tests/Authorization/Strategy/UnanimousStrategyTest.php

@@ -20,14 +20,14 @@ public function provideStrategyTests(): iterable
     {
         $strategy = new UnanimousStrategy();
 
-        yield [$strategy, static::getVoters(1, 0, 0), true];
-        yield [$strategy, static::getVoters(1, 0, 1), true];
-        yield [$strategy, static::getVoters(1, 1, 0), false];
+        yield [$strategy, self::getVoters(1, 0, 0), true];
+        yield [$strategy, self::getVoters(1, 0, 1), true];
+        yield [$strategy, self::getVoters(1, 1, 0), false];
 
-        yield [$strategy, static::getVoters(0, 0, 2), false];
+        yield [$strategy, self::getVoters(0, 0, 2), false];
 
         $strategy = new UnanimousStrategy(true);
 
-        yield [$strategy, static::getVoters(0, 0, 2), true];
+        yield [$strategy, self::getVoters(0, 0, 2), true];
     }
 }