Merge branch '5.4' into 6.2

* 5.4:
  [Translation][Mailer] Convert `$this` calls to static ones in data providers
  [BC Break] Make data providers for abstract test cases static
  use TestCase suffix for abstract tests in Tests directories
  Fix Request locale property doc types
  Bump absolute lowest dep to 4.4

Author: nicolas-grekas

CHANGELOG.md

@@ -18,6 +18,11 @@ CHANGELOG
    or `LegacyPasswordAuthenticatedUserInterface` instead
 * `AccessDecisionManager` requires the strategy to be passed as in instance of `AccessDecisionStrategyInterface`
 
+5.4.21
+------
+
+ * [BC BREAK] `AccessDecisionStrategyTestCase::provideStrategyTests()` is now static
+
 5.4
 ---
 

Test/AccessDecisionStrategyTestCase.php

@@ -40,7 +40,7 @@ final public function testDecide(AccessDecisionStrategyInterface $strategy, arra
     /**
      * @return iterable<array{AccessDecisionStrategyInterface, VoterInterface[], bool}>
      */
-    abstract public function provideStrategyTests(): iterable;
+    abstract public static function provideStrategyTests(): iterable;
 
     /**
      * @return VoterInterface[]

Tests/Authorization/Strategy/AffirmativeStrategyTest.php

@@ -16,7 +16,7 @@
 
 class AffirmativeStrategyTest extends AccessDecisionStrategyTestCase
 {
-    public function provideStrategyTests(): iterable
+    public static function provideStrategyTests(): iterable
     {
         $strategy = new AffirmativeStrategy();
 

Tests/Authorization/Strategy/ConsensusStrategyTest.php

@@ -16,7 +16,7 @@
 
 class ConsensusStrategyTest extends AccessDecisionStrategyTestCase
 {
-    public function provideStrategyTests(): iterable
+    public static function provideStrategyTests(): iterable
     {
         $strategy = new ConsensusStrategy();
 

Tests/Authorization/Strategy/PriorityStrategyTest.php

@@ -17,7 +17,7 @@
 
 class PriorityStrategyTest extends AccessDecisionStrategyTestCase
 {
-    public function provideStrategyTests(): iterable
+    public static function provideStrategyTests(): iterable
     {
         $strategy = new PriorityStrategy();
 

Tests/Authorization/Strategy/UnanimousStrategyTest.php

@@ -16,7 +16,7 @@
 
 class UnanimousStrategyTest extends AccessDecisionStrategyTestCase
 {
-    public function provideStrategyTests(): iterable
+    public static function provideStrategyTests(): iterable
     {
         $strategy = new UnanimousStrategy();