Use typed properties in tests as much as possible

Author: nicolas-grekas

Tests/Authentication/Token/AbstractTokenTest.php

@@ -96,7 +96,7 @@ public function testSetUser($user)
 
 class ConcreteToken extends AbstractToken
 {
-    private $credentials = 'credentials_value';
+    private string $credentials = 'credentials_value';
 
     public function __construct(array $roles = [], UserInterface $user = null)
     {

Tests/Authorization/AccessDecisionManagerTest.php

@@ -255,7 +255,7 @@ protected static function getVoters($grants, $denies, $abstains): array
     protected static function getVoter($vote)
     {
         return new class($vote) implements VoterInterface {
-            private $vote;
+            private int $vote;
 
             public function __construct(int $vote)
             {

Tests/Authorization/AuthorizationCheckerTest.php

@@ -11,6 +11,7 @@
 
 namespace Symfony\Component\Security\Core\Tests\Authorization;
 
+use PHPUnit\Framework\MockObject\MockObject;
 use PHPUnit\Framework\TestCase;
 use Symfony\Component\Security\Core\Authentication\Token\NullToken;
 use Symfony\Component\Security\Core\Authentication\Token\Storage\TokenStorage;
@@ -21,9 +22,9 @@
 
 class AuthorizationCheckerTest extends TestCase
 {
-    private $accessDecisionManager;
-    private $authorizationChecker;
-    private $tokenStorage;
+    private MockObject&AccessDecisionManagerInterface $accessDecisionManager;
+    private AuthorizationChecker $authorizationChecker;
+    private TokenStorage $tokenStorage;
 
     protected function setUp(): void
     {

Tests/Authorization/Voter/VoterTest.php

@@ -18,7 +18,7 @@
 
 class VoterTest extends TestCase
 {
-    protected $token;
+    protected TokenInterface $token;
 
     protected function setUp(): void
     {

Tests/Validator/Constraints/UserPasswordValidatorTestCase.php

@@ -29,20 +29,9 @@ abstract class UserPasswordValidatorTestCase extends ConstraintValidatorTestCase
     private const PASSWORD = 's3Cr3t';
     private const SALT = '^S4lt$';
 
-    /**
-     * @var TokenStorageInterface
-     */
-    protected $tokenStorage;
-
-    /**
-     * @var PasswordHasherInterface
-     */
-    protected $hasher;
-
-    /**
-     * @var PasswordHasherFactoryInterface
-     */
-    protected $hasherFactory;
+    protected TokenStorageInterface $tokenStorage;
+    protected PasswordHasherInterface $hasher;
+    protected PasswordHasherFactoryInterface $hasherFactory;
 
     protected function createValidator(): UserPasswordValidator
     {