bug #23341 [DoctrineBridge][Security][Validator] do not validate empty values (xabbuh)

fabpot · fabpot · commit a3268fef01e9 · 2017-07-03T10:38:34.000+03:00
This PR was merged into the 2.7 branch.

Discussion
----------

[DoctrineBridge][Security][Validator] do not validate empty values

| Q             | A
| ------------- | ---
| Branch?       | 2.7
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #23319
| License       | MIT
| Doc PR        |

Nearly all validators operating on scalar values (except for some special constraints) do ignore empty values. If you want to forbid them, you have to use the `NotBlank` constraint instead.

Commits
-------

fd7ad234bc do not validate empty values
diff --git a/Validator/Constraints/UserPasswordValidator.php b/Validator/Constraints/UserPasswordValidator.php
@@ -39,6 +39,10 @@ public function validate($password, Constraint $constraint)
             throw new UnexpectedTypeException($constraint, __NAMESPACE__.'\UserPassword');
         }
 
+        if (null === $password || '' === $password) {
+            return;
+        }
+
         $user = $this->tokenStorage->getToken()->getUser();
 
         if (!$user instanceof UserInterface) {

Original file line number	Diff line number	Diff line change
`@@ -39,6 +39,10 @@ public function validate($password, Constraint $constraint)`
`39`	`39`	`throw new UnexpectedTypeException($constraint, __NAMESPACE__.'\UserPassword');`
`40`	`40`	`}`
`41`	`41`
	`42`	`+ if (null === $password \|\| '' === $password) {`
	`43`	`+ return;`
	`44`	`+ }`
	`45`	`+`
`42`	`46`	`$user = $this->tokenStorage->getToken()->getUser();`
`43`	`47`
`44`	`48`	`if (!$user instanceof UserInterface) {`