minor #42490 More return type fixes (bis) (nicolas-grekas)

This PR was merged into the 5.4 branch.

Discussion
----------

More return type fixes (bis)

| Q             | A
| ------------- | ---
| Branch?       | 5.4
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       | -
| License       | MIT
| Doc PR        | -

Commits
-------

c6a20b4e4d More return type fixes (bis)

Author: nicolas-grekas

Authenticator/AbstractAuthenticator.php

@@ -28,8 +28,6 @@ abstract class AbstractAuthenticator implements AuthenticatorInterface
     /**
      * Shortcut to create a PostAuthenticationToken for you, if you don't really
      * care about which authenticated token you're using.
-     *
-     * @return PostAuthenticationToken
      */
     public function createToken(Passport $passport, string $firewallName): TokenInterface
     {

Authenticator/Passport/PassportTrait.php

@@ -20,6 +20,9 @@ trait PassportTrait
 {
     private $badges = [];
 
+    /**
+     * @return $this
+     */
     public function addBadge(BadgeInterface $badge): PassportInterface
     {
         $this->badges[\get_class($badge)] = $badge;

Tests/LoginLink/LoginLinkHandlerTest.php

@@ -203,40 +203,6 @@ private function createLinker(array $options = [], array $extraProperties = ['em
     }
 }
 
-class TestLoginLinkHandlerUserProvider implements UserProviderInterface
-{
-    private $users = [];
-
-    public function createUser(TestLoginLinkHandlerUser $user): void
-    {
-        $this->users[$user->getUserIdentifier()] = $user;
-    }
-
-    public function loadUserByUsername($username): TestLoginLinkHandlerUser
-    {
-        return $this->loadUserByIdentifier($username);
-    }
-
-    public function loadUserByIdentifier(string $userIdentifier): TestLoginLinkHandlerUser
-    {
-        if (!isset($this->users[$userIdentifier])) {
-            throw new UserNotFoundException();
-        }
-
-        return clone $this->users[$userIdentifier];
-    }
-
-    public function refreshUser(UserInterface $user)
-    {
-        return $this->users[$username];
-    }
-
-    public function supportsClass(string $class)
-    {
-        return TestLoginLinkHandlerUser::class === $class;
-    }
-}
-
 class TestLoginLinkHandlerUser implements UserInterface
 {
     public $username;
@@ -281,3 +247,37 @@ public function eraseCredentials()
     {
     }
 }
+
+class TestLoginLinkHandlerUserProvider implements UserProviderInterface
+{
+    private $users = [];
+
+    public function createUser(TestLoginLinkHandlerUser $user): void
+    {
+        $this->users[$user->getUserIdentifier()] = $user;
+    }
+
+    public function loadUserByUsername($username): TestLoginLinkHandlerUser
+    {
+        return $this->loadUserByIdentifier($username);
+    }
+
+    public function loadUserByIdentifier(string $userIdentifier): TestLoginLinkHandlerUser
+    {
+        if (!isset($this->users[$userIdentifier])) {
+            throw new UserNotFoundException();
+        }
+
+        return clone $this->users[$userIdentifier];
+    }
+
+    public function refreshUser(UserInterface $user)
+    {
+        return $this->users[$username];
+    }
+
+    public function supportsClass(string $class)
+    {
+        return TestLoginLinkHandlerUser::class === $class;
+    }
+}