Skip to content

Commit f4fe350

Browse files
committed
Merge branch '5.1' into 5.x
2 parents 0df5616 + 01fc5b3 commit f4fe350

File tree

2 files changed

+2
-3
lines changed

2 files changed

+2
-3
lines changed

Authentication/AuthenticatorManager.php

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -134,8 +134,7 @@ private function executeAuthenticators(array $authenticators, Request $request):
134134
foreach ($authenticators as $authenticator) {
135135
// recheck if the authenticator still supports the listener. supports() is called
136136
// eagerly (before token storage is initialized), whereas authenticate() is called
137-
// lazily (after initialization). This is important for e.g. the AnonymousAuthenticator
138-
// as its support is relying on the (initialized) token in the TokenStorage.
137+
// lazily (after initialization).
139138
if (false === $authenticator->supports($request)) {
140139
if (null !== $this->logger) {
141140
$this->logger->debug('Skipping the "{authenticator}" authenticator as it did not support the request.', ['authenticator' => \get_class($authenticator)]);

Tests/Authentication/AuthenticatorManagerTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,7 @@ public function testSupportCheckedUponRequestAuthentication()
7373
{
7474
// the attribute stores the supported authenticators, returning false now
7575
// means support changed between calling supports() and authenticateRequest()
76-
// (which is the case with lazy firewalls and e.g. the AnonymousAuthenticator)
76+
// (which is the case with lazy firewalls)
7777
$authenticator = $this->createAuthenticator(false);
7878
$this->request->attributes->set('_security_authenticators', [$authenticator]);
7979

0 commit comments

Comments
 (0)