Merge branch '6.4' into 7.0

fabpot · fabpot · commit f84d7d3c93e6 · 2023-11-26T18:09:17.000+01:00
* 6.4:
  CS: typo fix
  [Security] make secret required for DefaultLoginRateLimiter
diff --git a/RateLimiter/DefaultLoginRateLimiter.php b/RateLimiter/DefaultLoginRateLimiter.php
@@ -34,7 +34,7 @@ final class DefaultLoginRateLimiter extends AbstractRequestRateLimiter
     /**
      * @param non-empty-string $secret A secret to use for hashing the IP address and username
      */
-    public function __construct(RateLimiterFactory $globalFactory, RateLimiterFactory $localFactory, #[\SensitiveParameter] string $secret = '')
+    public function __construct(RateLimiterFactory $globalFactory, RateLimiterFactory $localFactory, #[\SensitiveParameter] string $secret)
     {
         if (!$secret) {
             throw new InvalidArgumentException('A non-empty secret is required.');

Original file line number	Diff line number	Diff line change
`@@ -34,7 +34,7 @@ final class DefaultLoginRateLimiter extends AbstractRequestRateLimiter`
`34`	`34`	`/**`
`35`	`35`	`* @param non-empty-string $secret A secret to use for hashing the IP address and username`
`36`	`36`	`*/`
`37`		`- public function __construct(RateLimiterFactory $globalFactory, RateLimiterFactory $localFactory, #[\SensitiveParameter] string $secret = '')`
	`37`	`+ public function __construct(RateLimiterFactory $globalFactory, RateLimiterFactory $localFactory, #[\SensitiveParameter] string $secret)`
`38`	`38`	`{`
`39`	`39`	`if (!$secret) {`
`40`	`40`	`throw new InvalidArgumentException('A non-empty secret is required.');`