Static code analysis with Php Inspections (EA Extended)

kalessil · fabpot · commit bdff202e7830 · 2017-02-16T14:26:15.000-08:00
diff --git a/Acl/Dbal/MutableAclProvider.php b/Acl/Dbal/MutableAclProvider.php
@@ -662,9 +662,8 @@ protected function getSelectSecurityIdentityIdSql(SecurityIdentityInterface $sid
     protected function getDeleteSecurityIdentityIdSql(SecurityIdentityInterface $sid)
     {
         $select = $this->getSelectSecurityIdentityIdSql($sid);
-        $delete = preg_replace('/^SELECT id FROM/', 'DELETE FROM', $select);
 
-        return $delete;
+        return preg_replace('/^SELECT id FROM/', 'DELETE FROM', $select);
     }
 
     /**

Original file line number	Diff line number	Diff line change
`@@ -662,9 +662,8 @@ protected function getSelectSecurityIdentityIdSql(SecurityIdentityInterface $sid`
`662`	`662`	`protected function getDeleteSecurityIdentityIdSql(SecurityIdentityInterface $sid)`
`663`	`663`	`{`
`664`	`664`	`$select = $this->getSelectSecurityIdentityIdSql($sid);`
`665`		`- $delete = preg_replace('/^SELECT id FROM/', 'DELETE FROM', $select);`
`666`	`665`
`667`		`- return $delete;`
	`666`	`+ return preg_replace('/^SELECT id FROM/', 'DELETE FROM', $select);`
`668`	`667`	`}`
`669`	`668`
`670`	`669`	`/**`