[CS][2.7] yoda_style, no_unneeded_curly_braces, no_unneeded_final_method, semicolon_after_instruction

Author: SpacePossum

Encoder/XmlEncoder.php

@@ -94,10 +94,10 @@ public function decode($data, $format, array $context = array())
 
         $rootNode = null;
         foreach ($dom->childNodes as $child) {
-            if ($child->nodeType === XML_DOCUMENT_TYPE_NODE) {
+            if (XML_DOCUMENT_TYPE_NODE === $child->nodeType) {
                 throw new UnexpectedValueException('Document types are not allowed.');
             }
-            if (!$rootNode && $child->nodeType !== XML_PI_NODE) {
+            if (!$rootNode && XML_PI_NODE !== $child->nodeType) {
                 $rootNode = $child;
             }
         }
@@ -339,7 +339,7 @@ private function parseXmlValue(\DOMNode $node)
         $value = array();
 
         foreach ($node->childNodes as $subnode) {
-            if ($subnode->nodeType === XML_PI_NODE) {
+            if (XML_PI_NODE === $subnode->nodeType) {
                 continue;
             }
 
@@ -388,7 +388,7 @@ private function buildXml(\DOMNode $parentNode, $data, $xmlRootNodeName = null)
                         $data = $this->serializer->normalize($data, $this->format, $this->context);
                     }
                     $parentNode->setAttribute($attributeName, $data);
-                } elseif ($key === '#') {
+                } elseif ('#' === $key) {
                     $append = $this->selectNodeType($parentNode, $data);
                 } elseif (is_array($data) && false === is_numeric($key)) {
                     // Is this array fully numeric keys?

Normalizer/AbstractNormalizer.php

@@ -325,7 +325,7 @@ protected function instantiateObject(array &$data, $class, array &$context, \Ref
                 $paramName = $constructorParameter->name;
                 $key = $this->nameConverter ? $this->nameConverter->normalize($paramName) : $paramName;
 
-                $allowed = $allowedAttributes === false || in_array($paramName, $allowedAttributes);
+                $allowed = false === $allowedAttributes || in_array($paramName, $allowedAttributes);
                 $ignored = in_array($paramName, $this->ignoredAttributes);
                 if (method_exists($constructorParameter, 'isVariadic') && $constructorParameter->isVariadic()) {
                     if ($allowed && !$ignored && (isset($data[$key]) || array_key_exists($key, $data))) {

Normalizer/GetSetMethodNormalizer.php

@@ -108,7 +108,7 @@ public function denormalize($data, $class, $format = null, array $context = arra
                 $attribute = $this->nameConverter->denormalize($attribute);
             }
 
-            $allowed = $allowedAttributes === false || in_array($attribute, $allowedAttributes);
+            $allowed = false === $allowedAttributes || in_array($attribute, $allowedAttributes);
             $ignored = in_array($attribute, $this->ignoredAttributes);
 
             if ($allowed && !$ignored) {

Normalizer/ObjectNormalizer.php

@@ -75,10 +75,10 @@ public function normalize($object, $format = null, array $context = array())
                 ) {
                     $name = $reflMethod->getName();
 
-                    if (strpos($name, 'get') === 0 || strpos($name, 'has') === 0) {
+                    if (0 === strpos($name, 'get') || 0 === strpos($name, 'has')) {
                         // getters and hassers
                         $attributes[lcfirst(substr($name, 3))] = true;
-                    } elseif (strpos($name, 'is') === 0) {
+                    } elseif (0 === strpos($name, 'is')) {
                         // issers
                         $attributes[lcfirst(substr($name, 2))] = true;
                     }
@@ -148,7 +148,7 @@ public function denormalize($data, $class, $format = null, array $context = arra
                 $attribute = $this->nameConverter->denormalize($attribute);
             }
 
-            $allowed = $allowedAttributes === false || in_array($attribute, $allowedAttributes);
+            $allowed = false === $allowedAttributes || in_array($attribute, $allowedAttributes);
             $ignored = in_array($attribute, $this->ignoredAttributes);
 
             if ($allowed && !$ignored) {

Normalizer/PropertyNormalizer.php

@@ -105,7 +105,7 @@ public function denormalize($data, $class, $format = null, array $context = arra
                 $propertyName = $this->nameConverter->denormalize($propertyName);
             }
 
-            $allowed = $allowedAttributes === false || in_array($propertyName, $allowedAttributes);
+            $allowed = false === $allowedAttributes || in_array($propertyName, $allowedAttributes);
             $ignored = in_array($propertyName, $this->ignoredAttributes);
             if ($allowed && !$ignored && $reflectionClass->hasProperty($propertyName)) {
                 $property = $reflectionClass->getProperty($propertyName);

Tests/Fixtures/ScalarDummy.php

@@ -23,12 +23,12 @@ class ScalarDummy implements NormalizableInterface, DenormalizableInterface
 
     public function normalize(NormalizerInterface $normalizer, $format = null, array $context = array())
     {
-        return $format === 'xml' ? $this->xmlFoo : $this->foo;
+        return 'xml' === $format ? $this->xmlFoo : $this->foo;
     }
 
     public function denormalize(DenormalizerInterface $denormalizer, $data, $format = null, array $context = array())
     {
-        if ($format === 'xml') {
+        if ('xml' === $format) {
             $this->xmlFoo = $data;
         } else {
             $this->foo = $data;