Remove all "nullable-by-default-value" setters

Author: nicolas-grekas

CHANGELOG.md

@@ -4,9 +4,12 @@ CHANGELOG
 6.2
 ---
 
-* Add support for constructor promoted properties to `Context` attribute
-* Add context option `PropertyNormalizer::NORMALIZE_VISIBILITY` with bitmask flags `PropertyNormalizer::NORMALIZE_PUBLIC`, `PropertyNormalizer::NORMALIZE_PROTECTED`, `PropertyNormalizer::NORMALIZE_PRIVATE`
-* Add method `withNormalizeVisibility` to `PropertyNormalizerContextBuilder`
+ * Add support for constructor promoted properties to `Context` attribute
+ * Add context option `PropertyNormalizer::NORMALIZE_VISIBILITY` with bitmask flags `PropertyNormalizer::NORMALIZE_PUBLIC`, `PropertyNormalizer::NORMALIZE_PROTECTED`, `PropertyNormalizer::NORMALIZE_PRIVATE`
+ * Add method `withNormalizeVisibility` to `PropertyNormalizerContextBuilder`
+ * Deprecate calling `AttributeMetadata::setSerializedName()`, `ClassMetadata::setClassDiscriminatorMapping()` without arguments
+ * Change the signature of `AttributeMetadataInterface::setSerializedName()` to `setSerializedName(?string)`
+ * Change the signature of `ClassMetadataInterface::setClassDiscriminatorMapping()` to `setClassDiscriminatorMapping(?ClassDiscriminatorMapping)`
 
 6.1
 ---

Mapping/AttributeMetadata.php

@@ -109,6 +109,10 @@ public function getMaxDepth(): ?int
 
     public function setSerializedName(string $serializedName = null)
     {
+        if (1 > \func_num_args()) {
+            trigger_deprecation('symfony/serializer', '6.2', 'Calling "%s()" without any arguments is deprecated, pass null explicitly instead.', __METHOD__);
+        }
+
         $this->serializedName = $serializedName;
     }
 

Mapping/AttributeMetadataInterface.php

@@ -52,7 +52,7 @@ public function getMaxDepth(): ?int;
     /**
      * Sets the serialization name for this attribute.
      */
-    public function setSerializedName(string $serializedName = null);
+    public function setSerializedName(?string $serializedName);
 
     /**
      * Gets the serialization name for this attribute.

Mapping/ClassMetadata.php

@@ -97,6 +97,9 @@ public function getClassDiscriminatorMapping(): ?ClassDiscriminatorMapping
 
     public function setClassDiscriminatorMapping(ClassDiscriminatorMapping $mapping = null)
     {
+        if (1 > \func_num_args()) {
+            trigger_deprecation('symfony/serializer', '6.2', 'Calling "%s()" without any arguments is deprecated, pass null explicitly instead.', __METHOD__);
+        }
         $this->classDiscriminatorMapping = $mapping;
     }
 

Mapping/ClassMetadataInterface.php

@@ -53,5 +53,5 @@ public function getReflectionClass(): \ReflectionClass;
 
     public function getClassDiscriminatorMapping(): ?ClassDiscriminatorMapping;
 
-    public function setClassDiscriminatorMapping(ClassDiscriminatorMapping $mapping = null);
+    public function setClassDiscriminatorMapping(?ClassDiscriminatorMapping $mapping);
 }