refReference: throw an exception when reference not found

Author: nikophil

_build/src/Reference/RefReference.php

@@ -17,7 +17,11 @@ public function getName(): string
     public function resolve(Environment $environment, string $data): ResolvedReference
     {
         $resolver = new Resolver();
-        dump($resolver->resolve($environment, $data));
-        return $resolver->resolve($environment, $data);
+        $resolvedReference = $resolver->resolve($environment, $data);
+        if ($resolvedReference->getTitle() === '(unresolved)') {
+            throw  new \RuntimeException(sprintf('Reference "%s" could not be resolved', $data));
+        }
+
+        return $resolvedReference;
     }
 }

_build/tests/IntegrationTest.php

@@ -17,12 +17,7 @@ class IntegrationTest extends TestCase
      */
     public function testIntegration(string $folder)
     {
-        $kernel  = new HtmlKernel();
-        $builder = new Builder($kernel);
-        $fs      = new Filesystem();
-        $fs->remove(__DIR__.'/_output');
-
-        $builder->build(
+        $this->createBuilder()->build(
             sprintf('%s/fixtures/source/%s', __DIR__, $folder),
             __DIR__.'/_output',
             true // verbose
@@ -35,7 +30,7 @@ public function testIntegration(string $folder)
 
         $indenter = new Indenter();
         foreach ($finder as $expectedFile) {
-            $relativePath = $expectedFile->getRelativePathname();
+            $relativePath   = $expectedFile->getRelativePathname();
             $actualFilename = __DIR__.'/_output/'.$relativePath;
             $this->assertFileExists($actualFilename);
 
@@ -47,16 +42,20 @@ public function testIntegration(string $folder)
 
     public function integrationProvider()
     {
-//        yield 'main' => [
-//            'folder' => 'main'
-//        ];
+        //        yield 'main' => [
+        //            'folder' => 'main'
+        //        ];
 
         yield 'toctree' => [
-            'folder' => 'toctree'
+            'folder' => 'toctree',
         ];
 
         yield 'refReference' => [
-            'folder' => 'refReference'
+            'folder' => 'refReference',
+        ];
+
+        yield 'refReferenceError' => [
+            'folder' => 'refReferenceError',
         ];
     }
 
@@ -135,4 +134,25 @@ public function parserUnitBlockProvider()
             'documentName' => 'literal',
         ];
     }
+
+    public function testRefReferenceError()
+    {
+        $this->expectException(\RuntimeException::class);
+
+        $this->createBuilder()->build(
+            sprintf('%s/fixtures/source/refReferenceError', __DIR__),
+            __DIR__.'/_output',
+            true // verbose
+        );
+    }
+
+    private function createBuilder(): Builder
+    {
+        $kernel  = new HtmlKernel();
+        $builder = new Builder($kernel);
+        $fs      = new Filesystem();
+        $fs->remove(__DIR__.'/_output');
+
+        return $builder;
+    }
 }

_build/tests/fixtures/source/refReferenceError/index.rst

@@ -0,0 +1,2 @@
+
+:ref:`A ref test <ref-test>`.