Adding that you cannot access a session inside a constructor

ThomasLandauer · web-flow · commit 1208abab3325 · 2022-07-15T15:56:12.000+02:00
Please double-check! The info is taken from PhpStorm's Symfony Plugin: https://espend.de/phpstorm/plugin/symfony#inspections: > A Session must not be used inside a constructor I think this should be explained here, since doing `$this->session = $requestStack->getSession();` right in the constructor looked like a nice idea...
diff --git a/session.rst b/session.rst
@@ -149,6 +149,9 @@ if you type-hint an argument with :class:`Symfony\\Component\\HttpFoundation\\Re
         public function __construct(RequestStack $requestStack)
         {
             $this->requestStack = $requestStack;
+            
+            // This does *not* work, since you cannot access the session inside a constructor
+            // $this->session = $requestStack->getSession();
         }
 
         public function someMethod()

Original file line number	Diff line number	Diff line change
@@ -149,6 +149,9 @@ if you type-hint an argument with :class:`Symfony\\Component\\HttpFoundation\\Re
`149`	`149`	`public function __construct(RequestStack $requestStack)`
`150`	`150`	`{`
`151`	`151`	`$this->requestStack = $requestStack;`
	`152`	`+`
	`153`	`+ // This does not work, since you cannot access the session inside a constructor`
	`154`	`+ // $this->session = $requestStack->getSession();`
`152`	`155`	`}`
`153`	`156`
`154`	`157`	`public function someMethod()`