You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
minor #8621 Path package in context aware (takman1)
This PR was merged into the 3.3 branch.
Discussion
----------
Path package in context aware
How to reproduce :
- Application has a base url (/some-base-url)
- Using "PathPackage"
- Using RequestStackContext (3rd parameter),
- getUrl of asset with absolute path.
Result :
Both "base url" of application and "base path" of PathPackage are ignored.
Example :
Application base url : /some-prefix
$package = new PathPackage('/static/', new StaticVersionStrategy('v1.2'), new RequestStackContext($requestStack));
echo $package->getUrl("/img.png"); // /img.png?v1.2
Check merged PR #8574.
NB : Maybe there a conception problem in Asset component. I my opinion only "base path" should be ignored but "base url" should always be used to prefix the generated asset path.
Commits
-------
0dbb635 Path package in context aware
0 commit comments