Skip to content

Commit 179abb0

Browse files
Nyholmjaviereguiluz
authored andcommitted
Updated according to feedback
1 parent a281604 commit 179abb0

File tree

1 file changed

+15
-13
lines changed

1 file changed

+15
-13
lines changed

bundles/best_practices.rst

Lines changed: 15 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -182,18 +182,16 @@ test latest beta release. Here is a recommended configuration file (``.travis.ym
182182
- $HOME/.composer/cache/files
183183
env:
184184
global:
185-
- TEST_COMMAND="phpunit"
185+
- TEST_COMMAND="./vendor/bin/simple-phpunit"
186186
187187
matrix:
188188
fast_finish: true
189189
include:
190190
# Minimum supported PHP and Symfony version
191-
- php: 5.5
192-
env: DEPENDENCIES="minimum" COVERAGE=true TEST_COMMAND="phpunit --coverage-text"
191+
- php: 7.2
192+
env: DEPENDENCIES="minimum" COVERAGE=true TEST_COMMAND="phpunit --coverage-text" SYMFONY_DEPRECATIONS_HELPER="weak"
193193
194194
# Test the latest stable release
195-
- php: 5.5
196-
- php: 5.6
197195
- php: 7.0
198196
- php: 7.1
199197
- php: 7.2
@@ -204,30 +202,33 @@ test latest beta release. Here is a recommended configuration file (``.travis.ym
204202
- php: 7.2
205203
env: DEPENDENCIES="symfony/lts:v3"
206204
207-
# Latest beta release
205+
# Latest commit to master
208206
- php: 7.2
209-
env: DEPENDENCIES="beta"
207+
env: DEPENDENCIES="dev"
210208
211209
allow_failures:
212210
# Latest beta is allowed to fail.
213211
- php: 7.2
214-
env: DEPENDENCIES="beta"
212+
env: DEPENDENCIES="dev"
215213
216214
before_install:
215+
- composer require --no-update "symfony/phpunit-bridge:^3.3 || ^4"
217216
- if [[ $COVERAGE != true ]]; then phpenv config-rm xdebug.ini || true; fi
218217
- if [ "$DEPENDENCIES" = "minimum" ]; then COMPOSER_FLAGS="--prefer-stable --prefer-lowest"; fi;
219-
- if [ "$DEPENDENCIES" = "beta" ]; then composer config minimum-stability beta; fi;
218+
- if [ "$DEPENDENCIES" = "dev" ]; then composer config minimum-stability dev; fi;
220219
- if [[ $DEPENDENCIES == *"/"* ]]; then composer require --no-update $DEPENDENCIES; fi;
221220
222221
install:
223222
# To be removed when this issue will be resolved: https://github.com/composer/composer/issues/5355
224-
- if [[ "$COMPOSER_FLAGS" == *"--prefer-lowest"* ]]; then travis_retry composer update --prefer-dist --no-interaction --prefer-stable --quiet; fi
225-
- travis_retry composer update ${COMPOSER_FLAGS} --prefer-dist --no-interaction
223+
- if [[ "$COMPOSER_FLAGS" == *"--prefer-lowest"* ]]; then composer update --prefer-dist --no-interaction --prefer-stable --quiet; fi
224+
- composer update ${COMPOSER_FLAGS} --prefer-dist --no-interaction
226225
227226
script:
227+
- composer validate --strict --no-check-lock
228228
- $TEST_COMMAND
229229
230-
230+
When configuring travis you should also enable `Travis cron`_ to make sure your
231+
project is build even if there is no new pull requests or commits.
231232

232233
Installation
233234
------------
@@ -539,4 +540,5 @@ Learn more
539540
.. _`Packagist`: https://packagist.org/
540541
.. _`choose any license`: http://choosealicense.com/
541542
.. _`valid license identifier`: https://spdx.org/licenses/
542-
.. _`Travis CI`: travis-ci.org
543+
.. _`Travis CI`: https://travis-ci.org/
544+
.. _`Travis Cron`: https://docs.travis-ci.com/user/cron-jobs/

0 commit comments

Comments
 (0)