Skip to content

Commit 23b6250

Browse files
committed
Merge branch '5.3' into 5.4
* 5.3: Update pull_requests.rst Update pull_requests.rst
2 parents f7355bd + ca08be6 commit 23b6250

File tree

1 file changed

+8
-8
lines changed

1 file changed

+8
-8
lines changed

contributing/code/pull_requests.rst

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,12 @@
11
Proposing a Change
22
==================
33

4+
.. admonition:: Screencast
5+
:class: screencast
6+
7+
Do you prefer video tutorials? Check out the `Contributing Back To Symfony`_
8+
screencast series.
9+
410
A pull request, "PR" for short, is the best way to provide a bug fix or to
511
propose enhancements to Symfony.
612

@@ -101,12 +107,6 @@ Check that the current Tests Pass
101107
Now that Symfony is installed, check that all unit tests pass for your
102108
environment as explained in the dedicated :doc:`document <tests>`.
103109

104-
.. tip::
105-
106-
If tests are failing, check on `Travis-CI`_ if the same test is
107-
failing there as well. In that case you do not need to be concerned
108-
about the test failing locally.
109-
110110
.. _step-2-work-on-your-patch:
111111

112112
Step 3: Work on your Pull Request
@@ -246,7 +246,7 @@ in mind the following:
246246
as defined in `PSR-1`_ and `PSR-2`_.
247247

248248
A status is posted below the pull request description with a summary
249-
of any problems it detects or any `Travis-CI`_ build failures.
249+
of any problems it detects or any GitHub Actions build failures.
250250

251251
.. _prepare-your-patch-for-submission:
252252

@@ -527,5 +527,5 @@ before merging.
527527
.. _`PSR-2`: https://www.php-fig.org/psr/psr-2/
528528
.. _`searching on GitHub`: https://github.com/symfony/symfony/issues?q=+is%3Aopen+
529529
.. _`Symfony Slack`: https://symfony.com/slack-invite
530-
.. _`Travis-CI`: https://travis-ci.org/symfony/symfony
531530
.. _`Psalm phar is installed`: https://psalm.dev/docs/running_psalm/installation/
531+
.. _`Contributing Back To Symfony`: https://symfonycasts.com/screencast/contributing

0 commit comments

Comments
 (0)