clean nodes

Author: nikophil

_build/src/Nodes/AnchorNode.php

@@ -8,7 +8,7 @@ class AnchorNode extends Base
 {
     public function render(): string
     {
-        return '<span id="'.$this->value.'"></span>';
+        return sprintf('<span id="%s"></span>', $this->value);
     }
 }
 

_build/src/Nodes/ClassTrait.php

@@ -0,0 +1,25 @@
+<?php
+
+namespace SymfonyDocs\Nodes;
+
+trait ClassTrait
+{
+    /** @var string */
+    private $class;
+
+    /**
+     * @return string
+     */
+    public function getClass(): ?string
+    {
+        return $this->class;
+    }
+
+    /**
+     * @param string $class
+     */
+    public function setClass(?string $class)
+    {
+        $this->class = $class;
+    }
+}

_build/src/Nodes/CodeNode.php

@@ -58,11 +58,7 @@ public function render(): string
 
         $lineNumbers = "";
         for ($i = 1; $i <= \count($lines); $i++) {
-            $iAsString = (string) $i;
-            if (strlen($iAsString) == 1) {
-                $iAsString = " ".$iAsString;
-            }
-            $lineNumbers .= $iAsString."\n";
+            $lineNumbers .= str_pad((string) $i, 2, ' ', STR_PAD_LEFT)."\n";
         }
 
         $language = $this->getLanguage() ?? 'php';
@@ -85,14 +81,9 @@ public function render(): string
         );
     }
 
-    /**
-     * @return string[]
-     */
     private function getLines(string $code): array
     {
-        $lines = preg_split('/\r\n|\r|\n/', $code);
-        assert(is_array($lines));
-
+        $lines         = preg_split('/\r\n|\r|\n/', $code);
         $reversedLines = array_reverse($lines);
 
         // trim empty lines at the end of the code

_build/src/Nodes/ListNode.php

@@ -6,17 +6,13 @@
 
 class ListNode extends Base
 {
-    /** @var string */
-    private $class = '';
+    use ClassTrait;
 
     protected function createElement(string $text, string $prefix): string
     {
         return sprintf('<li>%s</li>', $text);
     }
 
-    /**
-     * @return string[]
-     */
     protected function createList(bool $ordered): array
     {
         $keyword = $ordered ? 'ol' : 'ul';
@@ -26,24 +22,4 @@ protected function createList(bool $ordered): array
             sprintf('</%s>', $keyword),
         ];
     }
-
-    /**
-     * @return string
-     */
-    public function getClass(): ?string
-    {
-        return $this->class;
-    }
-
-    /**
-     * @param string $class
-     *
-     * @return $this
-     */
-    public function setClass(?string $class)
-    {
-        $this->class = $class;
-
-        return $this;
-    }
 }

_build/src/Nodes/ParagraphNode.php

@@ -8,30 +8,9 @@
 
 class ParagraphNode extends Base
 {
-    /** @var string */
-    private $class = '';
+    use ClassTrait;
 
-    /**
-     * @return string
-     */
-    public function getClass(): ?string
-    {
-        return $this->class;
-    }
-
-    /**
-     * @param string $class
-     *
-     * @return $this
-     */
-    public function setClass(?string $class)
-    {
-        $this->class = $class;
-
-        return $this;
-    }
-
-    public function render() : string
+    public function render(): string
     {
         if ($this->value instanceof Node) {
             $text = trim($this->value->render());
@@ -44,7 +23,7 @@ public function render() : string
                 return sprintf('<p class="%s">%s</p>', $this->class, $text);
             }
 
-            return '<p>' . $text . '</p>';
+            return sprintf('<p>%s</p>', $text);
         }
 
         return '';

_build/src/Nodes/SpanNode.php

@@ -6,9 +6,9 @@
 
 class SpanNode extends Span
 {
-    public function literal(string $text) : string
+    public function literal(string $text): string
     {
-        return '<code class="notranslate">' . $text . '</code>';
+        return sprintf('<code class="notranslate">%s</code>', $text);
     }
 
     public function link(?string $url, string $title, array $attributes = []): string
@@ -21,6 +21,7 @@ public function link(?string $url, string $title, array $attributes = []): strin
             $title = '<em>'.$title.'</em>';
             unset($attributes['is-doc']);
         }
+
         if (!$attributes) {
             $attributes['class'] = sprintf('reference %s', 0 === strpos($url, 'http') ? 'external' : 'internal');
         }
@@ -36,6 +37,10 @@ static function ($attribute, $value) {
             )
         );
 
-        return '<a href="'.htmlspecialchars((string) $url).'"'.($htmlAttributes !== '' ? ' '.$htmlAttributes : '').'>'.$title.'</a>';
+        if ($htmlAttributes) {
+            $htmlAttributes = ' '.$htmlAttributes;
+        }
+
+        return sprintf('<a href="%s"%s>%s</a>', htmlspecialchars((string) $url), $htmlAttributes, $title);
     }
 }

_build/src/Nodes/TitleNode.php

@@ -11,7 +11,14 @@ public function render(): string
     {
         $anchor = Environment::slugify((string) $this->value);
 
-        return '<h'.$this->level.' id="'.$anchor.'">'.$this->value.'<a class="headerlink" href="#'.$anchor.'" title="Permalink to this headline">¶</a></h'.$this->level.'>';
+        return sprintf(
+            '<h%s id="%s">%s<a class="headerlink" href="#%s" title="Permalink to this headline">¶</a></h%s>',
+            $this->level,
+            $anchor,
+            $this->value,
+            $anchor,
+            $this->level
+        );
     }
 }
 

_build/src/Nodes/TocNode.php

@@ -34,16 +34,8 @@ public function render(): string
         return $html;
     }
 
-    /**
-     * @param mixed[]|array $titles
-     * @param mixed[]       $path
-     */
-    private function renderLevel(
-        ?string $url,
-        array $titles,
-        int $level = 1,
-        array $path = []
-    ): string {
+    private function renderLevel(?string $url, array $titles, int $level = 1, array $path = []): string
+    {
         if (-1 !== $this->depth && $level > $this->depth) {
             return '';
         }
@@ -63,7 +55,7 @@ private function renderLevel(
             $anchor = Environment::slugify($slug);
             $target = $url;
             if (1 !== $level) {
-                $target = $url . '#' . $anchor;
+                $target = $url.'#'.$anchor;
             }
 
             if (is_array($title)) {
@@ -83,7 +75,6 @@ private function renderLevel(
             }
 
             $html .= '</li>';
-
         }
 
         return $html;