Skip to content

Commit 3e2b876

Browse files
Nyholmjaviereguiluz
authored andcommitted
Fixed typos and created more variables
1 parent a62bcb7 commit 3e2b876

File tree

1 file changed

+8
-10
lines changed

1 file changed

+8
-10
lines changed

bundles/best_practices.rst

Lines changed: 8 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -170,7 +170,7 @@ Travis
170170
------
171171

172172
A popular way to test open source bundles is by using `Travis CI`_. A good practice
173-
is to support at least the two latest LTS versions of symfony. One should also test
173+
is to support at least the two latest LTS versions of Symfony. One should also test
174174
test latest beta release. Here is a recommended configuration file (``.travis.yml``).
175175

176176
.. code-block:: yaml
@@ -190,16 +190,15 @@ test latest beta release. Here is a recommended configuration file (``.travis.ym
190190
matrix:
191191
fast_finish: true
192192
include:
193-
# Minimum supported Symfony version
194-
- php: 7.2
195-
env: DEPENDENCIES="minimum" COVERAGE=true TEST_COMMAND="phpunit --coverage-text" SYMFONY_DEPRECATIONS_HELPER="weak"
193+
# Minimum supported Symfony version with the latest PHP version
194+
- env: COMPOSER_FLAGS="--prefer-stable --prefer-lowest" COVERAGE=true TEST_COMMAND="./vendor/bin/simple-phpunit --coverage-text" SYMFONY_DEPRECATIONS_HELPER="weak"
196195
197196
# Test the latest stable release
198197
- php: 7.0
199198
- php: 7.1
200199
- php: 7.2
201200
202-
# Test LTS versions. This makes sure we do not use symfony packages with version greater
201+
# Test LTS versions. This makes sure we do not use Symfony packages with version greater
203202
# than 2 or 3 respectively. Read more at https://github.com/symfony/lts
204203
- php: 7.2
205204
env: DEPENDENCIES="symfony/lts:^2"
@@ -208,19 +207,18 @@ test latest beta release. Here is a recommended configuration file (``.travis.ym
208207
209208
# Latest commit to master
210209
- php: 7.2
211-
env: DEPENDENCIES="dev"
210+
env: STABILITY="dev"
212211
213212
allow_failures:
214213
# Latest beta is allowed to fail.
215214
- php: 7.2
216-
env: DEPENDENCIES="dev"
215+
env: STABILITY="dev"
217216
218217
before_install:
219218
- composer require --no-update "symfony/phpunit-bridge:^3.3 || ^4"
220219
- if [[ $COVERAGE != true ]]; then phpenv config-rm xdebug.ini || true; fi
221-
- if [ "$DEPENDENCIES" = "minimum" ]; then COMPOSER_FLAGS="--prefer-stable --prefer-lowest"; fi;
222-
- if [ "$DEPENDENCIES" = "dev" ]; then composer config minimum-stability dev; fi;
223-
- if [[ $DEPENDENCIES == *"/"* ]]; then composer require --no-update $DEPENDENCIES; fi;
220+
- if [[ -v $STABILITY ]]; then composer config minimum-stability $STABILITY; fi;
221+
- if [[ -v $DEPENDENCIES ]]; then composer require --no-update $DEPENDENCIES; fi;
224222
225223
install:
226224
# To be removed when this issue will be resolved: https://github.com/composer/composer/issues/5355

0 commit comments

Comments
 (0)