Skip to content

Commit 55b21d2

Browse files
authored
Some text improvements
1 parent 66422d5 commit 55b21d2

File tree

1 file changed

+23
-23
lines changed

1 file changed

+23
-23
lines changed

best_practices.rst

Lines changed: 23 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -81,8 +81,8 @@ Configuration
8181
Use Environment Variables for Infrastructure Configuration
8282
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
8383

84-
The values of these options change from one machine to another (e.g. from your
85-
development machine to the production server) but they don't modify the
84+
The values of these options change from one machine to another (e.g., from your
85+
development machine to the production server), but they don't modify the
8686
application behavior.
8787

8888
:ref:`Use env vars in your project <config-env-vars>` to define these options
@@ -93,7 +93,7 @@ and create multiple ``.env`` files to :ref:`configure env vars per environment <
9393
Use Secrets for Sensitive Information
9494
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
9595

96-
When your application has sensitive configuration - like an API key - you should
96+
When your application has sensitive configuration, like an API key, you should
9797
store those securely via :doc:`Symfony’s secrets management system </configuration/secrets>`.
9898

9999
Use Parameters for Application Configuration
@@ -119,7 +119,7 @@ Then, use just one or two words to describe the purpose of the parameter:
119119
120120
# config/services.yaml
121121
parameters:
122-
# don't do this: 'dir' is too generic and it doesn't convey any meaning
122+
# don't do this: 'dir' is too generic, and it doesn't convey any meaning
123123
app.dir: '...'
124124
# do this: short but easy to understand names
125125
app.contents_dir: '...'
@@ -164,7 +164,7 @@ InvoiceBundle, etc. However, a bundle is meant to be something that can be
164164
reused as a stand-alone piece of software.
165165

166166
If you need to reuse some feature in your projects, create a bundle for it (in a
167-
private repository, to not make it publicly available). For the rest of your
167+
private repository, do not make it publicly available). For the rest of your
168168
application code, use PHP namespaces to organize code instead of bundles.
169169

170170
Use Autowiring to Automate the Configuration of Application Services
@@ -186,14 +186,14 @@ Services Should be Private Whenever Possible
186186
those services via ``$container->get()``. Instead, you will need to use proper
187187
dependency injection.
188188

189-
Use the YAML Format to Configure your Own Services
189+
Use the YAML Format to Configure your own Services
190190
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
191191

192192
If you use the :ref:`default services.yaml configuration <service-container-services-load-example>`,
193193
most services will be configured automatically. However, in some edge cases
194194
you'll need to configure services (or parts of them) manually.
195195

196-
YAML is the format recommended to configure services because it's friendly to
196+
YAML is the format recommended configuring services because it's friendly to
197197
newcomers and concise, but Symfony also supports XML and PHP configuration.
198198

199199
Use Attributes to Define the Doctrine Entity Mapping
@@ -228,13 +228,13 @@ important parts of your application.
228228

229229
.. _best-practice-controller-annotations:
230230

231-
Use Attributes or Annotations to Configure Routing, Caching and Security
231+
Use Attributes or Annotations to Configure Routing, Caching, and Security
232232
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
233233

234-
Using attributes or annotations for routing, caching and security simplifies
234+
Using attributes or annotations for routing, caching, and security simplifies
235235
configuration. You don't need to browse several files created with different
236-
formats (YAML, XML, PHP): all the configuration is just where you need it and
237-
it only uses one format.
236+
formats (YAML, XML, PHP): all the configuration is just where you require it,
237+
and it only uses one format.
238238

239239
Use Dependency Injection to Get Services
240240
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
@@ -256,15 +256,15 @@ controller. It will also show a 404 page if no entity can be found.
256256

257257
If the logic to get an entity from a route variable is more complex, instead of
258258
configuring the EntityValueResolver, it's better to make the Doctrine query
259-
inside the controller (e.g. by calling to a :doc:`Doctrine repository method </doctrine>`).
259+
inside the controller (e.g., by calling to a :doc:`Doctrine repository method </doctrine>`).
260260

261261
Templates
262262
---------
263263

264264
Use Snake Case for Template Names and Variables
265265
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
266266

267-
Use lowercase snake_case for template names, directories and variables (e.g.
267+
Use lowercase snake_case for template names, directories, and variables (e.g.,
268268
``user_profile`` instead of ``userProfile`` and ``product/edit_form.html.twig``
269269
instead of ``Product/EditForm.html.twig``).
270270

@@ -273,7 +273,7 @@ Prefix Template Fragments with an Underscore
273273

274274
Template fragments, also called *"partial templates"*, allow to
275275
:ref:`reuse template contents <templates-reuse-contents>`. Prefix their names
276-
with an underscore to better differentiate them from complete templates (e.g.
276+
with an underscore to better differentiate them from complete templates (e.g.,
277277
``_user_metadata.html.twig`` or ``_caution_message.html.twig``).
278278

279279
Forms
@@ -282,7 +282,7 @@ Forms
282282
Define your Forms as PHP Classes
283283
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
284284

285-
Creating :ref:`forms in classes <creating-forms-in-classes>` allows to reuse
285+
Creating :ref:`forms in classes <creating-forms-in-classes>` allows reusing
286286
them in different parts of the application. Besides, not creating forms in
287287
controllers simplifies the code and maintenance of the controllers.
288288

@@ -294,7 +294,7 @@ button of a form used to both create and edit items should change from "Add new"
294294
to "Save changes" depending on where it's used.
295295

296296
Instead of adding buttons in form classes or the controllers, it's recommended
297-
to add buttons in the templates. This also improves the separation of concerns,
297+
to add buttons in the templates. This also improves the separation of concerns
298298
because the button styling (CSS class and other attributes) is defined in the
299299
template instead of in a PHP class.
300300

@@ -316,7 +316,7 @@ Use a Single Action to Render and Process the Form
316316

317317
:ref:`Rendering forms <rendering-forms>` and :ref:`processing forms <processing-forms>`
318318
are two of the main tasks when handling forms. Both are too similar (most of the
319-
times, almost identical), so it's much simpler to let a single controller action
319+
time, almost identical), so it's much simpler to let a single controller action
320320
handle both.
321321

322322
.. _best-practice-internationalization:
@@ -340,8 +340,8 @@ Use Keys for Translations Instead of Content Strings
340340
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
341341

342342
Using keys simplifies the management of the translation files because you can
343-
change the original contents in templates, controllers and services without
344-
having to update all of the translation files.
343+
change the original contents in templates, controllers, and services without
344+
having to update all the translation files.
345345

346346
Keys should always describe their *purpose* and *not* their location. For
347347
example, if a form has a field with the label "Username", then a nice key
@@ -354,7 +354,7 @@ Define a Single Firewall
354354
~~~~~~~~~~~~~~~~~~~~~~~~
355355

356356
Unless you have two legitimately different authentication systems and users
357-
(e.g. form login for the main site and a token system for your API only), it's
357+
(e.g., form login for the main site and a token system for your API only), it's
358358
recommended to have only one firewall to keep things simple.
359359

360360
Additionally, you should use the ``anonymous`` key under your firewall. If you
@@ -381,13 +381,13 @@ Web Assets
381381
Use Webpack Encore to Process Web Assets
382382
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
383383

384-
Web assets are things like CSS, JavaScript and image files that make the
384+
Web assets are things like CSS, JavaScript, and image files that make the
385385
frontend of your site look and work great. `Webpack`_ is the leading JavaScript
386386
module bundler that compiles, transforms and packages assets for usage in a browser.
387387

388388
:doc:`Webpack Encore </frontend>` is a JavaScript library that gets rid of most
389389
of Webpack complexity without hiding any of its features or distorting its usage
390-
and philosophy. It was originally created for Symfony applications, but it works
390+
and philosophy. It was created for Symfony applications, but it works
391391
for any application using any technology.
392392

393393
Tests
@@ -445,7 +445,7 @@ public URL changes, users won't be able to browse it unless you set up a
445445
redirection to the new URL.
446446

447447
That's why it's recommended to use raw URLs in tests instead of generating them
448-
from routes. Whenever a route changes, tests will fail and you'll know that
448+
from routes. Whenever a route changes, tests will fail, and you'll know that
449449
you must set up a redirection.
450450

451451
.. _`Symfony Demo`: https://github.com/symfony/demo

0 commit comments

Comments
 (0)