Skip to content

Commit 8416432

Browse files
author
Ca-Jou
committed
changes made after review
1 parent 0225889 commit 8416432

File tree

2 files changed

+4
-7
lines changed

2 files changed

+4
-7
lines changed

create_framework/event_dispatcher.rst

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -45,9 +45,6 @@ the Response instance::
4545

4646
class Framework
4747
{
48-
49-
/* all properties are now declared as private, they were protected until this chapter -> either there is a good reason and it might be useful to explain this change, or there could be better coherence by keeping them protected *or* private in the entire book */
50-
5148
private $dispatcher;
5249
private $matcher;
5350
private $controllerResolver;

create_framework/http_kernel_httpkernelinterface.rst

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -46,8 +46,8 @@ Update your framework so that it implements this interface::
4646
}
4747
}
4848

49-
Even if this change doesn't look like much, it brings us a lot! Let's talk about one of
50-
the most impressive ones: transparent :doc:`HTTP caching </http_cache>` support.
49+
With this change, a little goes a long way! Let's talk about one of
50+
the most impressive upsides: transparent :doc:`HTTP caching </http_cache>` support.
5151

5252
The ``HttpCache`` class implements a fully-featured reverse proxy, written in
5353
PHP; it implements ``HttpKernelInterface`` and wraps another
@@ -64,8 +64,8 @@ PHP; it implements ``HttpKernelInterface`` and wraps another
6464
new HttpKernel\HttpCache\Store(__DIR__.'/../cache')
6565
);
6666

67-
/* $response variable used before and after this chapter -> keep it in this chapter for more global coherence? */
68-
$framework->handle($request)->send();
67+
$response = $framework->handle($request);
68+
$response->send();
6969

7070
That's all it takes to add HTTP caching support to our framework. Isn't it
7171
amazing?

0 commit comments

Comments
 (0)