Skip to content

Commit 848cabc

Browse files
committed
minor #7447 [DependencyInjection][Fix] Missing RequestStack (20uf)
This PR was merged into the 3.2 branch. Discussion ---------- [DependencyInjection][Fix] Missing RequestStack Hello, Since the 2.8 the RouterListener object needs the RequestStack object for the second argument. It was optional until version 3.0, eg: - http://api.symfony.com/2.8/Symfony/Component/HttpKernel/EventListener/RouterListener.html - http://api.symfony.com/3.0/Symfony/Component/HttpKernel/EventListener/RouterListener.html As you can see, it lacks in the following example and causes a significant error: - http://symfony.com/doc/current/create_framework/dependency_injection.html Regards, Commits ------- 823b3b0 [DependencyInjection][Fix] Missing RequestStack
2 parents 9e32792 + 823b3b0 commit 848cabc

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

create_framework/dependency_injection.rst

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,15 +20,16 @@ to it::
2020
{
2121
$context = new Routing\RequestContext();
2222
$matcher = new Routing\Matcher\UrlMatcher($routes, $context);
23+
$requestStack = new RequestStack();
2324

2425
$controllerResolver = new HttpKernel\Controller\ControllerResolver();
2526
$argumentResolver = new HttpKernel\Controller\ArgumentResolver();
2627

2728
$dispatcher = new EventDispatcher();
28-
$dispatcher->addSubscriber(new HttpKernel\EventListener\RouterListener($matcher));
29+
$dispatcher->addSubscriber(new HttpKernel\EventListener\RouterListener($matcher, $requestStack));
2930
$dispatcher->addSubscriber(new HttpKernel\EventListener\ResponseListener('UTF-8'));
3031

31-
parent::__construct($dispatcher, $controllerResolver, new RequestStack(), $argumentResolver);
32+
parent::__construct($dispatcher, $controllerResolver, $requestStack, $argumentResolver);
3233
}
3334
}
3435

0 commit comments

Comments
 (0)