Merge branch '5.3' into 5.4

* 5.3:
  [Session] Update configurations

Author: javiereguiluz

components/http_foundation/session_configuration.rst

@@ -29,7 +29,7 @@ All native save handlers are internal to PHP and as such, have no public facing
 They must be configured by ``php.ini`` directives, usually ``session.save_path`` and
 potentially other driver specific directives. Specific details can be found in
 the docblock of the ``setOptions()`` method of each class. For instance, the one
-provided by the Memcached extension can be found on :phpmethod:`php.net <Memcached::setOption>`.
+provided by the Memcached extension can be found on :phpmethod:`php.net <Memcached::setOptions>`.
 
 While native save handlers can be activated by directly using
 ``ini_set('session.save_handler', $name);``, Symfony provides a convenient way to
@@ -170,12 +170,39 @@ collection. That's why Symfony now overwrites this value to ``1``.
 If you wish to use the original value set in your ``php.ini``, add the following
 configuration:
 
-.. code-block:: yaml
+.. configuration-block::
 
-    # config/packages/framework.yaml
-    framework:
-        session:
-            gc_probability: null
+    .. code-block:: yaml
+
+        # config/packages/framework.yaml
+        framework:
+            session:
+                gc_probability: null
+
+    .. code-block:: xml
+
+        <!-- config/packages/framework.xml -->
+        <?xml version="1.0" encoding="UTF-8" ?>
+        <container xmlns="http://symfony.com/schema/dic/services"
+            xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+            xmlns:framework="http://symfony.com/schema/dic/symfony"
+            xsi:schemaLocation="http://symfony.com/schema/dic/services
+                https://symfony.com/schema/dic/services/services-1.0.xsd
+                http://symfony.com/schema/dic/symfony https://symfony.com/schema/dic/symfony/symfony-1.0.xsd">
+
+            <framework:config>
+                <framework:session gc_probability="null"/>
+            </framework:config>
+        </container>
+
+    .. code-block:: php
+
+        // config/packages/framework.php
+        $container->loadFromExtension('framework', [
+            'session' => [
+                'gc_probability' => null,
+            ],
+        ]);
 
 You can configure these settings by passing ``gc_probability``, ``gc_divisor``
 and ``gc_maxlifetime`` in an array to the constructor of

session.rst

@@ -201,41 +201,49 @@ your ``Session`` object with the default ``AttributeBag`` by the ``NamespacedAtt
         session.namespacedattributebag:
             class: Symfony\Component\HttpFoundation\Session\Attribute\NamespacedAttributeBag
 
-.. code-block:: php
+    .. code-block:: xml
 
-    namespace App\Session;
+        <!-- config/services.xml -->
+        <?xml version="1.0" encoding="UTF-8" ?>
+        <container xmlns="http://symfony.com/schema/dic/services"
+            xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+            xsi:schemaLocation="http://symfony.com/schema/dic/services https://symfony.com/schema/dic/services/services-1.0.xsd">
+
+            <services>
+                <service id="session" class="Symfony\Component\HttpFoundation\Session\Session" public="true">
+                    <argument type="service" id="session.storage"/>
+                    <argument type="service" id="session.namespacedattributebag"/>
+                    <argument type="service" id="session.flash_bag"/>
+                </service>
+
+                <service id="session.namespacedattributebag"
+                    class="Symfony\Component\HttpFoundation\Session\Attribute\NamespacedAttributeBag"
+                />
+            </services>
+        </container>
 
-    use Symfony\Component\HttpFoundation\RequestStack;
-    use Symfony\Component\HttpFoundation\Session\Attribute\NamespacedAttributeBag;
-    use Symfony\Component\HttpFoundation\Session\Session;
-    use Symfony\Component\HttpFoundation\Session\SessionInterface;
-    use Symfony\Component\HttpFoundation\Session\Storage\SessionStorageFactoryInterface;
+    .. code-block:: php
 
-    class SessionFactory
-    {
-        private $requestStack;
-        private $storageFactory;
-        private $usageReporter;
-        private $sessionAttributes;
+        // config/services.php
+        namespace Symfony\Component\DependencyInjection\Loader\Configurator;
 
-        public function __construct(RequestStack $requestStack, SessionStorageFactoryInterface $storageFactory, callable $usageReporter, NamespacedAttributeBag $sessionAttributes)
-        {
-            $this->requestStack = $requestStack;
-            $this->storageFactory = $storageFactory;
-            $this->usageReporter = $usageReporter;
-            $this->sessionAttributes = $sessionAttributes;
-        }
+        use Symfony\Component\HttpFoundation\Session\Attribute\NamespacedAttributeBag;
+        use Symfony\Component\HttpFoundation\Session\Session;
 
-        public function createSession(): SessionInterface
-        {
-            return new Session(
-                $this->storageFactory->createStorage($this->requestStack->getMainRequest()),
-                $this->sessionAttributes,
-                null,
-                $this->usageReporter
-            );
-        }
-    }
+        return function(ContainerConfigurator $configurator) {
+            $services = $configurator->services();
+
+            $services->set('session', Session::class)
+                ->public()
+                ->args([
+                    ref('session.storage'),
+                    ref('session.namespacedattributebag'),
+                    ref('session.flash_bag'),
+                ])
+            ;
+
+            $services->set('session.namespacedattributebag', NamespacedAttributeBag::class);
+        };
 
 .. _session-avoid-start:
 

session/database.rst

@@ -63,8 +63,6 @@ First, define a Symfony service for the connection to the Redis server:
 
     .. code-block:: php
 
-        use Symfony\Component\DependencyInjection\Reference;
-
         // ...
         $container
             // you can also use \RedisArray, \RedisCluster or \Predis\Client classes
@@ -105,13 +103,15 @@ and ``RedisProxy``:
                      and the expiration time for any given entry (in seconds), defaults are 'sf_s' and null:
                 <argument type="collection">
                     <argument key="prefix">my_prefix</argument>
+                    <argument key="ttl">600</argument>
                 </argument> -->
             </service>
         </services>
 
     .. code-block:: php
 
         // config/services.php
+        use Symfony\Component\DependencyInjection\Reference;
         use Symfony\Component\HttpFoundation\Session\Storage\Handler\RedisSessionHandler;
 
         $container
@@ -208,7 +208,7 @@ first register a new handler service with your database credentials:
                     <argument>%env(DATABASE_URL)%</argument>
 
                     <!-- you can also use PDO configuration, but requires passing two arguments: -->
-                    <!-- <argument>mysql:dbname=mydatabase, host=myhost</argument>
+                    <!-- <argument>mysql:dbname=mydatabase; host=myhost; port=myport</argument>
                         <argument type="collection">
                             <argument key="db_username">myuser</argument>
                             <argument key="db_password">mypassword</argument>