You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
minor #9676 Update compiler_passes.rst (DonCallisto)
This PR was submitted for the 4.0 branch but it was merged into the 3.4 branch instead (closes#9676).
Discussion
----------
Update compiler_passes.rst
I think that `findDefinition` is better than `getDefinition` as it will also look at aliases.
I found this by myself while migrating from sf < 3.4 to sf >= 3.4.
In particular I was following [this](https://symfony.com/doc/current/service_container/3.3-di-changes.html) and at point 2 services managed directly by `CompilerPass` were never founded.
Moreover - not related directly to this PR - I'm not sure that this "split" `getDefinition`/`findDefinition`/`getAlias` is really useful, but maybe I don't have the bigger picture.
WDYT?
PS.: Maybe this edit could be applied not only for sf 4 but also for previous versions?
Commits
-------
9b26fce Update compiler_passes.rst
0 commit comments