minor #12484 Remove Address's argument (auipga)

javiereguiluz · javiereguiluz · commit a906482f0610 · 2019-10-16T09:17:41.000+02:00
This PR was submitted for the master branch but it was merged into the 4.3 branch instead (closes #12484). Discussion ---------- Remove Address's argument Address has no second argument, so I removed it. NamedAddress can be used as alternative. I didn't write a bug for this. Commits ------- 5b0797b Remove Address's argument
diff --git a/mailer.rst b/mailer.rst
@@ -146,9 +146,13 @@ both strings or address objects::
         // email address as an object
         ->from(new Address('fabien@example.com'))
 
-        // email address as an object (email clients will display the name
-        // instead of the email address)
-        ->from(new NamedAddress('fabien@example.com', 'Fabien'))
+        // defining the email address and name as an object
+        // (email clients will display the name)
+        ->from(new Address('fabien@example.com'))
+
+        // defining the email address and name as a string
+        // (the format must match: 'Name <email@example.com>')
+        ->from(Address::fromString('Fabien Potencier <fabien@example.com>'))
 
         // ...
     ;
@@ -283,7 +287,7 @@ for Twig templates::
 
     $email = (new TemplatedEmail())
         ->from('fabien@example.com')
-        ->to(new NamedAddress('ryan@example.com', 'Ryan'))
+        ->to(new Address('ryan@example.com'))
         ->subject('Thanks for signing up!')
 
         // path of the Twig template to render

-Original file line number
+Diff line change
         // email address as an object
         ->from(new Address('[email protected]'))
 -        // email address as an object (email clients will display the name
 -        // instead of the email address)
 -        ->from(new NamedAddress('[email protected]', 'Fabien'))
 +        // defining the email address and name as an object
 +        // (email clients will display the name)
 +        ->from(new Address('[email protected]'))
++
 +        // defining the email address and name as a string
 +        // (the format must match: 'Name <[email protected]>')
 +        ->from(Address::fromString('Fabien Potencier <[email protected]>'))
         // ...
+    ;
     $email = (new TemplatedEmail())
         ->from('[email protected]')
 -        ->to(new NamedAddress('[email protected]', 'Ryan'))
 +        ->to(new Address('[email protected]'))
         ->subject('Thanks for signing up!')
         // path of the Twig template to render