Skip to content

Commit e0d59cd

Browse files
committed
minor #13312 [Notifier] Update round robin transport explanation (jschaedl)
This PR was merged into the 5.0 branch. Discussion ---------- [Notifier] Update round robin transport explanation As you can see in https://github.com/symfony/symfony/blob/master/src/Symfony/Component/Notifier/Transport/RoundRobinTransport.php#L72 only the next scheduled transport is used to send the message and not all transports. <!-- If your pull request fixes a BUG, use the oldest maintained branch that contains the bug (see https://symfony.com/roadmap for the list of maintained branches). If your pull request documents a NEW FEATURE, use the same Symfony branch where the feature was introduced (and `master` for features of unreleased versions). --> Commits ------- 35d9e1e Update round robin transport explaination
2 parents 451c9fd + 35d9e1e commit e0d59cd

File tree

1 file changed

+6
-5
lines changed

1 file changed

+6
-5
lines changed

notifier.rst

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -256,8 +256,8 @@ transport:
256256
# Slack errored
257257
main: '%env(SLACK_DSN)% || %env(TELEGRAM_DSN)%'
258258
259-
# Always send notifications to both Slack and Telegram
260-
all: '%env(SLACK_DSN)% && %env(TELEGRAM_DSN)%'
259+
# Send notifications to the next scheduled transport calculated by round robin
260+
roundrobin: '%env(SLACK_DSN)% && %env(TELEGRAM_DSN)%'
261261
262262
.. code-block:: xml
263263
@@ -279,7 +279,8 @@ transport:
279279
%env(SLACK_DSN)% || %env(TELEGRAM_DSN)%
280280
</framework:chatter-transport>
281281
282-
<!-- Always send notifications to both Slack and Telegram -->
282+
<!-- Send notifications to the next scheduled transport
283+
calculated by round robin -->
283284
<framework:chatter-transport name="slack">
284285
%env(SLACK_DSN)% && %env(TELEGRAM_DSN)%
285286
</framework:chatter-transport>
@@ -297,8 +298,8 @@ transport:
297298
// Slack errored
298299
'main' => '%env(SLACK_DSN)% || %env(TELEGRAM_DSN)%',
299300
300-
// Always send notifications to both Slack and Telegram
301-
'all' => '%env(SLACK_DSN)% && %env(TELEGRAM_DSN)%',
301+
// Send notifications to the next scheduled transport calculated by round robin
302+
'roundrobin' => '%env(SLACK_DSN)% && %env(TELEGRAM_DSN)%',
302303
],
303304
],
304305
]);

0 commit comments

Comments
 (0)