fix all references test, with title and css classes

nikophil · nikophil · commit fac409232c85 · 2018-09-30T18:00:42.000+02:00
diff --git a/_build/composer.lock b/_build/composer.lock
diff --git a/_build/notes.md b/_build/notes.md
@@ -11,5 +11,4 @@ Notes
 
 - warning about exceptions thrown and abortOnError conf
 - add some format check on references
-- test other notation for api reference
 - conf file, at least for sf version
diff --git a/_build/src/Reference/ClassReference.php b/_build/src/Reference/ClassReference.php
@@ -21,7 +21,12 @@ public function resolve(Environment $environment, string $data): ResolvedReferen
 
         return new ResolvedReference(
             $className,
-            sprintf('%s/%s/%s.html', self::BASE__URL, '4.1', str_replace('\\', '/', $className))
+            sprintf('%s/%s/%s.html', self::BASE__URL, '4.1', str_replace('\\', '/', $className)),
+            [],
+            [
+                'class' => 'reference external',
+                'title' => $className,
+            ]
         );
     }
 }
diff --git a/_build/src/Reference/MethodReference.php b/_build/src/Reference/MethodReference.php
@@ -24,7 +24,12 @@ public function resolve(Environment $environment, string $data): ResolvedReferen
 
         return new ResolvedReference(
             $methodName.'()',
-            sprintf('%s/%s/%s.html#method_%s', self::BASE__URL, '4.1', str_replace('\\', '/', $className), $methodName)
+            sprintf('%s/%s/%s.html#method_%s', self::BASE__URL, '4.1', str_replace('\\', '/', $className), $methodName),
+            [],
+            [
+                'class' => 'reference external',
+                'title' => sprintf('%s::%s()', $className, $methodName),
+            ]
         );
     }
 }
diff --git a/_build/src/Reference/NamespaceReference.php b/_build/src/Reference/NamespaceReference.php
@@ -20,8 +20,13 @@ public function resolve(Environment $environment, string $data): ResolvedReferen
         $className = str_replace('\\\\', '\\', $data);
 
         return new ResolvedReference(
-            $className,
-            sprintf('%s/%s/%s.html', self::BASE__URL, '4.1', str_replace('\\', '/', $className))
+            substr(strrchr($className, '\\'), 1),
+            sprintf('%s/%s/%s.html', self::BASE__URL, '4.1', str_replace('\\', '/', $className)),
+            [],
+            [
+                'class' => 'reference external',
+                'title' => $className
+            ]
         );
     }
 }
diff --git a/_build/src/Reference/PhpClassReference.php b/_build/src/Reference/PhpClassReference.php
@@ -19,7 +19,12 @@ public function resolve(Environment $environment, string $data): ResolvedReferen
     {
         return new ResolvedReference(
             $data,
-            sprintf(self::BASE__URL, strtolower($data))
+            sprintf(self::BASE__URL, strtolower($data)),
+            [],
+            [
+                'class' => 'reference external',
+                'title' => $data,
+            ]
         );
     }
 }
diff --git a/_build/src/Reference/PhpFunctionReference.php b/_build/src/Reference/PhpFunctionReference.php
@@ -19,7 +19,12 @@ public function resolve(Environment $environment, string $data): ResolvedReferen
     {
         return new ResolvedReference(
             $data,
-            sprintf(self::BASE__URL, str_replace('_', '-', strtolower($data)))
+            sprintf(self::BASE__URL, str_replace('_', '-', strtolower($data))),
+            [],
+            [
+                'class' => 'reference external',
+                'title' => $data,
+            ]
         );
     }
 }
diff --git a/_build/src/Reference/PhpMethodReference.php b/_build/src/Reference/PhpMethodReference.php
@@ -17,12 +17,17 @@ public function getName(): string
 
     public function resolve(Environment $environment, string $data): ResolvedReference
     {
-        $class = explode('::', $data)[0];
+        $class  = explode('::', $data)[0];
         $method = explode('::', $data)[1];
 
         return new ResolvedReference(
             $data.'()',
-            sprintf(self::BASE__URL, strtolower($class), strtolower($method))
+            sprintf(self::BASE__URL, strtolower($class), strtolower($method)),
+            [],
+            [
+                'class' => 'reference external',
+                'title' => $class
+            ]
         );
     }
 }
diff --git a/_build/tests/fixtures/expected/blocks/class-reference.html b/_build/tests/fixtures/expected/blocks/class-reference.html
@@ -4,6 +4,6 @@
     <meta charset="utf-8" />
 </head>
 <body>
-<p><a class="reference external" href="https://api.symfony.com/4.1/Symfony/Component/HttpKernel/DependencyInjection/ContainerAwareHttpKernel.html" title="Symfony\Component\HttpKernel\DependencyInjection\ContainerAwareHttpKernel">Symfony\Component\HttpKernel\DependencyInjection\ContainerAwareHttpKernel</a></p>
+<p><a href="https://api.symfony.com/4.1/Symfony/Component/HttpKernel/DependencyInjection/ContainerAwareHttpKernel.html" class="reference external" title="Symfony\Component\HttpKernel\DependencyInjection\ContainerAwareHttpKernel">Symfony\Component\HttpKernel\DependencyInjection\ContainerAwareHttpKernel</a></p>
 </body>
 </html>
diff --git a/_build/tests/fixtures/expected/blocks/method-reference.html b/_build/tests/fixtures/expected/blocks/method-reference.html
@@ -4,6 +4,6 @@
     <meta charset="utf-8" />
 </head>
 <body>
-<p><a class="reference external" href="https://api.symfony.com/4.1/Symfony/Component/HttpFoundation/RequestStack.html#method_getCurrentRequest" title="Symfony\Component\HttpFoundation\RequestStack::getCurrentRequest()">getCurrentRequest()</a></p>
+<p><a href="https://api.symfony.com/4.1/Symfony/Component/HttpFoundation/RequestStack.html#method_getCurrentRequest" class="reference external" title="Symfony\Component\HttpFoundation\RequestStack::getCurrentRequest()">getCurrentRequest()</a></p>
 </body>
 </html>
diff --git a/_build/tests/fixtures/expected/blocks/namespace-reference.html b/_build/tests/fixtures/expected/blocks/namespace-reference.html
@@ -4,6 +4,6 @@
     <meta charset="utf-8" />
 </head>
 <body>
-<p><a class="reference external" href="https://api.symfony.com/4.1/Symfony/Component/HttpFoundation.html" title="Symfony\Component\HttpFoundation">HttpFoundation</a></p>
+<p><a href="https://api.symfony.com/4.1/Symfony/Component/HttpFoundation.html" class="reference external" title="Symfony\Component\HttpFoundation">HttpFoundation</a></p>
 </body>
 </html>
diff --git a/_build/tests/fixtures/expected/blocks/php-class-reference.html b/_build/tests/fixtures/expected/blocks/php-class-reference.html
@@ -4,6 +4,6 @@
     <meta charset="utf-8" />
 </head>
 <body>
-<p><a class="reference external" href="https://secure.php.net/manual/en/class.arrayaccess.php" title="ArrayAccess">ArrayAccess</a></p>
+<p><a href="https://secure.php.net/manual/en/class.arrayaccess.php" class="reference external" title="ArrayAccess">ArrayAccess</a></p>
 </body>
 </html>
diff --git a/_build/tests/fixtures/expected/blocks/php-function-reference.html b/_build/tests/fixtures/expected/blocks/php-function-reference.html
@@ -4,6 +4,6 @@
     <meta charset="utf-8" />
 </head>
 <body>
-<p><a class="reference external" href="https://secure.php.net/manual/en/function.trigger-error.php" title="ArrayAccess">trigger_error</a></p>
+<p><a href="https://secure.php.net/manual/en/function.trigger-error.php" class="reference external" title="trigger_error">trigger_error</a></p>
 </body>
 </html>
diff --git a/_build/tests/fixtures/expected/blocks/php-method-reference.html b/_build/tests/fixtures/expected/blocks/php-method-reference.html
@@ -4,6 +4,6 @@
     <meta charset="utf-8" />
 </head>
 <body>
-<p><a class="reference external" href="https://secure.php.net/manual/en/locale.getdefault.php" title="Locale">Locale::getDefault()</a></p>
+<p><a href="https://secure.php.net/manual/en/locale.getdefault.php" class="reference external" title="Locale">Locale::getDefault()</a></p>
 </body>
 </html>

Original file line number	Diff line number	Diff line change
`@@ -21,7 +21,12 @@ public function resolve(Environment $environment, string $data): ResolvedReferen`
`21`	`21`
`22`	`22`	`return new ResolvedReference(`
`23`	`23`	`$className,`
`24`		`- sprintf('%s/%s/%s.html', self::BASE__URL, '4.1', str_replace('\\', '/', $className))`
	`24`	`+ sprintf('%s/%s/%s.html', self::BASE__URL, '4.1', str_replace('\\', '/', $className)),`
	`25`	`+ [],`
	`26`	`+ [`
	`27`	`+ 'class' => 'reference external',`
	`28`	`+ 'title' => $className,`
	`29`	`+ ]`
`25`	`30`	`);`
`26`	`31`	`}`
`27`	`32`	`}`
Original file line number	Diff line number	Diff line change
`@@ -24,7 +24,12 @@ public function resolve(Environment $environment, string $data): ResolvedReferen`
`24`	`24`
`25`	`25`	`return new ResolvedReference(`
`26`	`26`	`$methodName.'()',`
`27`		`- sprintf('%s/%s/%s.html#method_%s', self::BASE__URL, '4.1', str_replace('\\', '/', $className), $methodName)`
	`27`	`+ sprintf('%s/%s/%s.html#method_%s', self::BASE__URL, '4.1', str_replace('\\', '/', $className), $methodName),`
	`28`	`+ [],`
	`29`	`+ [`
	`30`	`+ 'class' => 'reference external',`
	`31`	`+ 'title' => sprintf('%s::%s()', $className, $methodName),`
	`32`	`+ ]`
`28`	`33`	`);`
`29`	`34`	`}`
`30`	`35`	`}`
Original file line number	Diff line number	Diff line change
`@@ -19,7 +19,12 @@ public function resolve(Environment $environment, string $data): ResolvedReferen`
`19`	`19`	`{`
`20`	`20`	`return new ResolvedReference(`
`21`	`21`	`$data,`
`22`		`- sprintf(self::BASE__URL, strtolower($data))`
	`22`	`+ sprintf(self::BASE__URL, strtolower($data)),`
	`23`	`+ [],`
	`24`	`+ [`
	`25`	`+ 'class' => 'reference external',`
	`26`	`+ 'title' => $data,`
	`27`	`+ ]`
`23`	`28`	`);`
`24`	`29`	`}`
`25`	`30`	`}`
Original file line number	Diff line number	Diff line change
`@@ -17,12 +17,17 @@ public function getName(): string`
`17`	`17`
`18`	`18`	`public function resolve(Environment $environment, string $data): ResolvedReference`
`19`	`19`	`{`
`20`		`- $class = explode('::', $data)[0];`
	`20`	`+ $class = explode('::', $data)[0];`
`21`	`21`	`$method = explode('::', $data)[1];`
`22`	`22`
`23`	`23`	`return new ResolvedReference(`
`24`	`24`	`$data.'()',`
`25`		`- sprintf(self::BASE__URL, strtolower($class), strtolower($method))`
	`25`	`+ sprintf(self::BASE__URL, strtolower($class), strtolower($method)),`
	`26`	`+ [],`
	`27`	`+ [`
	`28`	`+ 'class' => 'reference external',`
	`29`	`+ 'title' => $class`
	`30`	`+ ]`
`26`	`31`	`);`
`27`	`32`	`}`
`28`	`33`	`}`