File tree Expand file tree Collapse file tree 1 file changed +7
-4
lines changed Expand file tree Collapse file tree 1 file changed +7
-4
lines changed Original file line number Diff line number Diff line change @@ -402,22 +402,25 @@ pressured to refactor your code immediately when someone provides feedback.
402
402
Automated Feedback
403
403
~~~~~~~~~~~~~~~~~~
404
404
405
- There are many automated scripts that will provide feedback on your PR .
405
+ There are many automated scripts that will provide feedback on a pull request .
406
406
407
407
fabbot
408
408
""""""
409
409
410
- `fabbot `_ will review code style, check for common typos and make sure your git
410
+ `fabbot `_ will review code style, check for common typos and make sure the git
411
411
history looks good. If there are any issues, fabbot will often suggest what changes
412
412
that should be done. Most of the time you get a command to run to automatically
413
413
fix the changes.
414
414
415
+ It is rare, but fabbot could be wrong. One should verify if the suggested changes
416
+ make sense and that they are related to the pull request.
417
+
415
418
Psalm
416
419
"""""
417
420
418
- `Psalm `_ will make a comment on your Pull Request if it discovers any potential
421
+ `Psalm `_ will make a comment on a pull request if it discovers any potential
419
422
type errors. The Psalm errors are not always correct, but each should be reviewed
420
- and discussed. A Pull Request should not update the Psalm baseline nor add ``@psalm- ``
423
+ and discussed. A pull request should not update the Psalm baseline nor add ``@psalm- ``
421
424
annotations.
422
425
423
426
After the `Psalm phar is installed `_, the analysis can be run locally with:
You can’t perform that action at this time.
0 commit comments