Skip to content

use use statement instead of namespace #11476

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 26, 2019
Merged

use use statement instead of namespace #11476

merged 1 commit into from
Apr 26, 2019

Conversation

OskarStark
Copy link
Contributor

No description provided.

@OskarStark OskarStark added this to the 4.2 milestone Apr 24, 2019
wouterj
wouterj reviewed Apr 24, 2019
View reviewed changes
@OskarStark OskarStark force-pushed the use-statements-instead-of-namespace branch from bf7040d to a1b6ded Compare April 24, 2019 11:35
@OskarStark OskarStark requested a review from wouterj April 25, 2019 08:48
wouterj
wouterj approved these changes Apr 25, 2019
View reviewed changes
Copy link
Member

@wouterj wouterj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me, the other one migh be a bit confusing

@OskarStark OskarStark merged commit a1b6ded into symfony:4.2 Apr 26, 2019
OskarStark added a commit that referenced this pull request Apr 26, 2019
@OskarStark
minor #11476 use use statement instead of namespace (OskarStark)
1bb7072 
This PR was merged into the 4.2 branch.

Discussion
----------

use use statement instead of namespace

<!--

If your pull request fixes a BUG, use the oldest maintained branch that contains
the bug (see https://symfony.com/roadmap for the list of maintained branches).

If your pull request documents a NEW FEATURE, use the same Symfony branch where
the feature was introduced (and `master` for features of unreleased versions).

-->

Commits
-------

a1b6ded use use statement instead of namespace
@OskarStark OskarStark deleted the use-statements-instead-of-namespace branch April 26, 2019 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@javiereguiluz javiereguiluz javiereguiluz approved these changes

@wouterj wouterj wouterj approved these changes

Assignees
No one assigned
Labels
Routing Status: Reviewed
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.
4 participants
@OskarStark @javiereguiluz @wouterj @carsonbot