Skip to content

[Security] Tell about request_matcher #11574

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 21, 2019
Merged

[Security] Tell about request_matcher #11574

merged 1 commit into from
Jun 21, 2019

Conversation

MatTheCat
Copy link
Contributor

Fixes #11564

OskarStark
OskarStark reviewed May 14, 2019
View reviewed changes
@MatTheCat
Copy link
Contributor Author

@OskarStark thanks for the suggestions! Do you know why the Add suggestion to batch is greyed? 🤔

suggestion

@OskarStark
Copy link
Contributor

@OskarStark thanks for the suggestions! Do you know why the Add suggestion to batch is greyed? 🤔

No, I don't know, but you can apply them one by one and squash the commits into one later. We can do this for you too when merging 👍

MatTheCat added a commit to MatTheCat/symfony-docs that referenced this pull request May 14, 2019
@MatTheCat @OskarStark
https://github.com/symfony/symfony-docs/pull/11574#discussion_r283684459
2f96822 
Co-Authored-By: Oskar Stark <[email protected]>
MatTheCat added a commit to MatTheCat/symfony-docs that referenced this pull request May 14, 2019
@MatTheCat @OskarStark
https://github.com/symfony/symfony-docs/pull/11574#discussion_r283684676
c5ed4c9 
Co-Authored-By: Oskar Stark <[email protected]>
MatTheCat added a commit to MatTheCat/symfony-docs that referenced this pull request May 14, 2019
@MatTheCat @OskarStark
https://github.com/symfony/symfony-docs/pull/11574#discussion_r283685039
4d4b9ed 
Co-Authored-By: Oskar Stark <[email protected]>
@MatTheCat
Copy link
Contributor Author

Okay I'm not squashing yet as I guess there will be more reviews coming.

@MatTheCat MatTheCat mentioned this pull request May 14, 2019
Closed
wouterj
wouterj approved these changes May 30, 2019
View reviewed changes
Copy link
Member

@wouterj wouterj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Left two minor comments and other than that, this is ready to be merged!

OskarStark
OskarStark approved these changes May 31, 2019
View reviewed changes
Copy link
Contributor

@OskarStark OskarStark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After the comments

MatTheCat added a commit to MatTheCat/symfony-docs that referenced this pull request May 31, 2019
@MatTheCat @OskarStark
https://github.com/symfony/symfony-docs/pull/11574#discussion_r283684459
dc4d23c 
Co-Authored-By: Oskar Stark <[email protected]>
MatTheCat added a commit to MatTheCat/symfony-docs that referenced this pull request May 31, 2019
@MatTheCat @OskarStark
https://github.com/symfony/symfony-docs/pull/11574#discussion_r283684676
1ce1c97 
Co-Authored-By: Oskar Stark <[email protected]>
MatTheCat added a commit to MatTheCat/symfony-docs that referenced this pull request May 31, 2019
@MatTheCat @OskarStark
https://github.com/symfony/symfony-docs/pull/11574#discussion_r283685039
e055ecd 
Co-Authored-By: Oskar Stark <[email protected]>
MatTheCat added a commit to MatTheCat/symfony-docs that referenced this pull request May 31, 2019
@MatTheCat
https://github.com/symfony/symfony-docs/pull/11574#discussion_r289200081
4994ec1
MatTheCat added a commit to MatTheCat/symfony-docs that referenced this pull request May 31, 2019
@MatTheCat
https://github.com/symfony/symfony-docs/pull/11574#discussion_r289199817
d2e6a64
@MatTheCat
Copy link
Contributor Author

Updated based on #11574 (comment) and #11574 (comment)

I let you review once again!

@MatTheCat
Copy link
Contributor Author

MatTheCat commented May 31, 2019 •
edited
Loading

BTW I don't see the SymfonyCloud check mentionned in https://symfony.com/doc/current/contributing/documentation/overview.html#review-your-changes

@OskarStark
Copy link
Contributor

OskarStark commented May 31, 2019 •
edited
Loading

Now you can see the CI Step, sometimes it’s lacking a bit behind 😊

@MatTheCat
Copy link
Contributor Author

Oh yeah I see it now 😅

@MatTheCat
Copy link
Contributor Author

Squashed and rebased.

@javiereguiluz javiereguiluz added this to the 3.4 milestone Jun 21, 2019
@javiereguiluz javiereguiluz changed the base branch from master to 3.4 June 21, 2019 15:05
@javiereguiluz
Copy link
Member

Thanks for restoring this missing doc and for the overall improvement of this article.I Congrats on your first Symfony Docs contribution too!

@javiereguiluz javiereguiluz merged commit 51a1644 into symfony:3.4 Jun 21, 2019
javiereguiluz added a commit that referenced this pull request Jun 21, 2019
@javiereguiluz
minor #11574 [Security] Tell about request_matcher (MatTheCat)
dd9ce78 
This PR was submitted for the master branch but it was merged into the 3.4 branch instead (closes #11574).

Discussion
----------

[Security] Tell about request_matcher

Fixes #11564

Commits
-------

51a1644 Tell about request_matcher
@MatTheCat MatTheCat deleted the ticket_11564 branch June 21, 2019 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wouterj wouterj wouterj approved these changes

@OskarStark OskarStark OskarStark approved these changes

Assignees
No one assigned
Labels
Security Status: Reviewed
Projects
None yet
Milestone
3.4
Development

Successfully merging this pull request may close these issues.
5 participants
@MatTheCat @OskarStark @javiereguiluz @wouterj @carsonbot