Skip to content

Require Dotenv component without --dev #11703

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 10, 2019
Merged

Conversation

bocharsky-bw
Copy link
Contributor

Looks like according to these changes: symfony/recipes#501 - Dotenv component is suggested to be added to require section of composer.json. Both symfony/skeleton and symfony/website-skeleton require it on prod

Looks like according to these changes: symfony/recipes#501 - Dotenv component is suggested to be added to `require` section of `composer.json`. Both `symfony/skeleton` and `symfony/website-skeleton` require it on prod
Copy link
Member

@wouterj wouterj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree. Thanks for proposing this change!

@javiereguiluz javiereguiluz added this to the 3.4 milestone Jun 10, 2019
@javiereguiluz
Copy link
Member

Thank you Victor.

@javiereguiluz javiereguiluz merged commit 3f7594d into symfony:3.4 Jun 10, 2019
javiereguiluz added a commit that referenced this pull request Jun 10, 2019
This PR was merged into the 3.4 branch.

Discussion
----------

Require Dotenv component without --dev

Looks like according to these changes: symfony/recipes#501 - Dotenv component is suggested to be added to `require` section of `composer.json`. Both `symfony/skeleton` and `symfony/website-skeleton` require it on prod

Commits
-------

3f7594d Require Dotenv component without --dev
@bocharsky-bw bocharsky-bw deleted the patch-8 branch June 10, 2019 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants