Skip to content

Reworded the docs about Doctrine events #12328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 22, 2019
Merged

Reworded the docs about Doctrine events #12328

merged 1 commit into from
Sep 22, 2019

Conversation

javiereguiluz
Copy link
Member

No description provided.

@javiereguiluz javiereguiluz added this to the 4.3 milestone Sep 16, 2019
@javiereguiluz javiereguiluz mentioned this pull request Sep 16, 2019
Closed
6 tasks
stof
stof reviewed Sep 16, 2019
View reviewed changes
@javiereguiluz javiereguiluz mentioned this pull request Sep 17, 2019
Closed
@stof
Copy link
Member

stof commented Sep 17, 2019

shouldn't this be merged in the 3.4 branch if we want to be able to remove the doc from the bundle ? 3.4 is still an active LTS, so its doc is still maintained.

@javiereguiluz
Copy link
Member Author

No, sorry. There are too many changes from 3.4 to 4.3. It's a merge nightmare. We're slowly applying the same idea as Symfony code ... fix only bugs (typos) in the older branches and new features (new docs or large rewordings) go to newer branches. That's why 4.3 is the target.

@stof
Copy link
Member

stof commented Sep 17, 2019

Then you need to close your PR on DoctrineBundle, as the link to the entity listeners doc of the bundle will still be needed by the 3.4 branch of the doc.

noniagriconomie
noniagriconomie reviewed Sep 17, 2019
View reviewed changes
noniagriconomie
noniagriconomie reviewed Sep 17, 2019
View reviewed changes
@javiereguiluz javiereguiluz mentioned this pull request Sep 19, 2019
Closed
javiereguiluz added a commit that referenced this pull request Sep 22, 2019
@javiereguiluz
minor #12328 Reworded the docs about Doctrine events (javiereguiluz)
a4476ce 
This PR was squashed before being merged into the 4.3 branch (closes #12328).

Discussion
----------

Reworded the docs about Doctrine events

Commits
-------

31940c5 Reworded the docs about Doctrine events
@javiereguiluz javiereguiluz merged commit 31940c5 into symfony:4.3 Sep 22, 2019
@javiereguiluz javiereguiluz deleted the doctrine_events branch September 22, 2019 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stof stof stof left review comments

@noniagriconomie noniagriconomie noniagriconomie left review comments

Assignees
No one assigned
Labels
Doctrine Status: Reviewed
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.
4 participants
@javiereguiluz @stof @noniagriconomie @carsonbot