Update Timezone.rst #12405
Merged
Update Timezone.rst #12405
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OskarStark
approved these changes
Oct 2, 2019
|
Nice attention to detail! Thanks Roland. |
javiereguiluz
added a commit
that referenced
this pull request
Oct 3, 2019
This PR was merged into the 4.3 branch. Discussion ---------- Update Timezone.rst we dont "create" anything, the option ensures valid string values that can be used with `IntlTimeZone::createTimeZone` without ever getting `Etc/Unknonwn` cc @javiereguiluz as we discussed this, i think this is more explicit Commits ------- d91ae2f Update Timezone.rst
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we dont "create" anything, the option ensures valid string values that can be used with
IntlTimeZone::createTimeZonewithout ever gettingEtc/Unknonwncc @javiereguiluz as we discussed this, i think this is more explicit