Skip to content

Fixes a typo in expiration.rst #12546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 29, 2019
Merged

Conversation

kane-menicou
Copy link
Contributor

@kane-menicou kane-menicou commented Oct 26, 2019

Fixes a small typo in the expiration.rst file

@javiereguiluz javiereguiluz added this to the 3.4 milestone Oct 28, 2019
@javiereguiluz
Copy link
Member

Kane, thanks for fixing this grammar issue. However, even if the phrase is correct now, I think it's wrong to say that: "you may recall that ..." Why should I recall that? Here's a reword proposal:

Before:

Most of the time, you will use the ``Cache-Control`` header. You may
recall that the ``Cache-Control`` header is used to specify many
different cache directives::

After:

Most of the time, you will use the ``Cache-Control`` header, which
is used to specify many different cache directives::

Would that read better to you? Thanks.

@kane-menicou
Copy link
Contributor Author

Yeah that makes much more sense, thanks.

@javiereguiluz
Copy link
Member

Thanks ... and congrats on your first Symfony Docs contribution!

javiereguiluz added a commit that referenced this pull request Oct 29, 2019
This PR was squashed before being merged into the 3.4 branch (closes #12546).

Discussion
----------

Fixes a typo in expiration.rst

Fixes a small typo in the expiration.rst file

Commits
-------

d973052 Fixes a typo in expiration.rst
@javiereguiluz javiereguiluz merged commit d973052 into symfony:3.4 Oct 29, 2019
@kane-menicou kane-menicou deleted the patch-2 branch October 29, 2019 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants