Fix log directory parameter #12580
Merged
Fix log directory parameter #12580
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kernel.logs_dir instead of kernel.log_dir
dbrumann
approved these changes
Nov 3, 2019
|
Good catch 👍 The parameter is deprecated anyway, but having this wrong in the 4.3 and 4.4 docs can be annoying. |
|
Do you know since when its deprecated? Because there is a |
|
I created a PR to add the missing directive: |
OskarStark
approved these changes
Nov 3, 2019
|
Good catch, thanks @merguezzz. |
OskarStark
added a commit
that referenced
this pull request
Nov 3, 2019
This PR was merged into the 4.3 branch. Discussion ---------- Fix log directory parameter kernel.logs_dir instead of kernel.log_dir Commits ------- c1d34a8 Correct log dir parameter
OskarStark
added a commit
that referenced
this pull request
Nov 3, 2019
…meter (OskarStark) This PR was merged into the 4.3 branch. Discussion ---------- Add missing deprecated directive for kernel.log_dir parameter Based on the feedback by @dbrumann in #12580 (comment) Commits ------- 4bdc7a8 Add missing deprecated directive for kernel.log_dir parameter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
kernel.logs_dir instead of kernel.log_dir