Skip to content

There are 5 events listed and not 4 #13065

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 7, 2020
Merged

Conversation

scriptibus
Copy link
Contributor

@scriptibus scriptibus commented Feb 6, 2020

There are 5 events listed and not 4

Copy link
Member

@xabbuh xabbuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would change the text to something like "provides the following authentication events".

@scriptibus
Copy link
Contributor Author

I would change the text to something like "provides the following authentication events".

@xabbuh Yes, sounds better and doesn't contain a number that might be wrong one day.

@javiereguiluz javiereguiluz added this to the 4.4 milestone Feb 7, 2020
@javiereguiluz
Copy link
Member

@scriptibus thanks ... and congrats on your first Symfony Docs contribution!

javiereguiluz added a commit that referenced this pull request Feb 7, 2020
…othnagel)

This PR was merged into the 4.4 branch.

Discussion
----------

There are 5 events listed and not 4

<!--

If your pull request fixes a BUG, use the oldest maintained branch that contains
the bug (see https://symfony.com/roadmap for the list of maintained branches).

If your pull request documents a NEW FEATURE, use the same Symfony branch where
the feature was introduced (and `master` for features of unreleased versions).

-->
There are 5 events listed and not 4

Commits
-------

d03c8db Changed the text so that it doesnt contain a number
6dda684 There are 5 events listed and not 4
@javiereguiluz javiereguiluz merged commit d03c8db into symfony:4.4 Feb 7, 2020
@scriptibus
Copy link
Contributor Author

@javiereguiluz Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants