Skip to content

Missing format parameter in few serialize calls #13315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 21, 2020
Merged

Missing format parameter in few serialize calls #13315

merged 1 commit into from
Oct 21, 2020

Conversation

Caligone
Copy link
Contributor

@Caligone Caligone commented Mar 7, 2020

wouterj
wouterj approved these changes Oct 4, 2020
View reviewed changes
Copy link
Member

@wouterj wouterj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm completely unsure how we missed this PR. Seems like the changes are 100% correct. 👍

@wouterj
Copy link
Member

wouterj commented Oct 21, 2020

Thanks @Caligone! I'm sorry for the long wait, but it's in now. Congratz on your first PR. I hope we can offer you a better experience in any further PRs.

@wouterj wouterj merged commit 4cfacc9 into symfony:4.4 Oct 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wouterj wouterj wouterj approved these changes

@maxhelias maxhelias maxhelias approved these changes

Assignees
No one assigned
Labels
Status: Reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Caligone @wouterj @maxhelias @carsonbot