Command naming conventions #15062
Merged
Command naming conventions #15062
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 5, 2021
fabpot
added a commit
to symfony/symfony
that referenced
this pull request
Mar 6, 2021
This PR was merged into the 4.4 branch. Discussion ---------- Fix #36973: Command description consistency | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | Fix #36973 | License | MIT | Doc PR | symfony/symfony-docs#15062 This rewords command descriptions and options to use consistent verb mood. Commits ------- 01e18b0 Fix #36973: Command description consistency
symfony-splitter
pushed a commit
to symfony/twig-bridge
that referenced
this pull request
Mar 6, 2021
This PR was merged into the 4.4 branch. Discussion ---------- Fix #36973: Command description consistency | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | Fix #36973 | License | MIT | Doc PR | symfony/symfony-docs#15062 This rewords command descriptions and options to use consistent verb mood. Commits ------- 01e18b039a Fix #36973: Command description consistency
fabpot
requested changes
Mar 6, 2021
carsonbot
added
Status: Needs Work
Status: Needs Review
and removed
Status: Needs Review
Status: Needs Work
labels
javiereguiluz
force-pushed
the
command-naming
branch
from
b6dfdaa to
60f8569
Compare
|
Dane, thanks for this contribution! Sorry it took us a bit to merge it. Congrats on your first Symfony Docs contribution 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a partial fix for symfony/symfony#36973, to be reviewed along with symfony/symfony#40387