Skip to content

[Translation] Update translation.rst #15263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 12, 2021

Conversation

noniagriconomie
Copy link
Contributor

@noniagriconomie noniagriconomie commented Apr 19, 2021

Related to https://github.com/symfony/symfony/blob/5.x/src/Symfony/Contracts/Translation/TranslatorInterface.php#L24
I propose to add this here, as not all projects uses ICU translations, so documenting the special %count% could be useful

@javiereguiluz javiereguiluz requested a review from wouterj April 20, 2021 14:57
@carsonbot carsonbot changed the title Update translation.rst [Translation] Update translation.rst Apr 20, 2021
@javiereguiluz
Copy link
Member

I'm not against adding this ... but the proposed location feels a bit odd. It's like we abruptly add some content in that section 🤔

@noniagriconomie
Copy link
Contributor Author

@javiereguiluz yes indeed, what do you think to move this tip after the:

Another complication is when you have translations that may or may not be plural, based on some variable: code example?
as it is question of the word plural here

@javiereguiluz javiereguiluz added this to the 5.3 milestone Aug 12, 2021
@javiereguiluz javiereguiluz changed the base branch from 5.2 to 5.3 August 12, 2021 13:48
@javiereguiluz
Copy link
Member

Thanks Antoine! At the end I did what you suggested and I moved this to the section that briefly mentions the pluralization of messages.

@noniagriconomie noniagriconomie deleted the patch-1 branch August 12, 2021 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants