Skip to content

Update pull_requests.rst #15818

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 17, 2021
Merged

Update pull_requests.rst #15818

merged 1 commit into from
Sep 17, 2021

Conversation

gnito-org
Copy link
Contributor

Removing the outdated references to Travis-CI. It was confusing when I tried to get up to speed on contributing.

@gnito-org gnito-org changed the base branch from 5.3 to 4.4 September 17, 2021 14:08
@gnito-org gnito-org requested a review from xabbuh as a code owner September 17, 2021 14:08
@javiereguiluz javiereguiluz changed the base branch from 4.4 to 5.3 September 17, 2021 14:33
@javiereguiluz javiereguiluz added this to the 4.4 milestone Sep 17, 2021
@javiereguiluz
Copy link
Member

@gnito-org thanks for this contribution!

I see that you created the PR against 5.3 and then changed the base to 4.4 using GitHub's interface. That sadly doesn't work ... but don't worry, the tool we use to merge PRs can rebase before merging, so we'll rebase this to 4.4. ourselves while merging. Thanks a lot!

@javiereguiluz javiereguiluz changed the base branch from 5.3 to 4.4 September 17, 2021 15:31
@javiereguiluz
Copy link
Member

Thank you @gnito-org.

@javiereguiluz javiereguiluz merged commit 990087a into symfony:4.4 Sep 17, 2021
@gnito-org gnito-org deleted the patch-3 branch September 19, 2021 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants