Skip to content

[CS] Add missing commas #15819

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 17, 2021
Merged

[CS] Add missing commas #15819

merged 1 commit into from
Sep 17, 2021

Conversation

sebpacz
Copy link
Contributor

@sebpacz sebpacz commented Sep 14, 2021

This PR adds missing commas to examples with multi-line arrays. Maybe it would be a good idea to add a new rule to https://github.com/OskarStark/doctor-rst?

@sebpacz sebpacz requested a review from xabbuh as a code owner September 14, 2021 19:49
@carsonbot carsonbot added this to the 4.4 milestone Sep 14, 2021
@OskarStark
Copy link
Contributor

Yes it is, but it is not so easy, I tried a few times

@javiereguiluz
Copy link
Member

Thank you Sebastian.

@javiereguiluz javiereguiluz merged commit 93c7e93 into symfony:4.4 Sep 17, 2021
@javiereguiluz
Copy link
Member

Please note that while upmerging this to 5.3, 5.4 and 6.0, many of these fixes were "removed" because those newer branches use the new PHP config format based on fluent interfaces instead of arrays. In any case, many fixes were kept, so thanks again for contributing this!

@sebpacz sebpacz deleted the cs-fixes branch September 23, 2021 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants