Skip to content

[DependencyInjection] Update debug.rst #15820

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 22, 2021
Merged

Conversation

aliz71
Copy link
Contributor

@aliz71 aliz71 commented Sep 15, 2021

The service ID should not be surrounded by a single quote.

@javiereguiluz
Copy link
Member

Did you experience some issue because of these quotes?

If I remember correctly, we added these quotes (here and in other commands across the docs) because not adding them causes problems for Windows users.

@aliz71
Copy link
Contributor Author

aliz71 commented Sep 17, 2021 via email

@javiereguiluz
Copy link
Member

Thanks for the feedback! This is now more confusing to me. I remember that when we add unneeded quotes in some command it's because someone using Windows asked us to do that because otherwise it fails.

@aliz71
Copy link
Contributor Author

aliz71 commented Sep 22, 2021 via email

@javiereguiluz
Copy link
Member

I've asked in https://symfony.com/slack and many developers using Windows replied. The summary is: if you use the basic cmd console, only the command WITHOUT quotes works; if you use any other advanced console/terminal, it works WITH and WITHOUT quotes.

So, we're merging this pull request because it makes it work for everybody. Thanks!

The service ID should not be surrounded by a single quote.
@javiereguiluz
Copy link
Member

Thank you Ali ... and congrats on your first Symfony Docs contribution 🎉

@javiereguiluz javiereguiluz merged commit 90eed8a into symfony:4.4 Sep 22, 2021
@carsonbot carsonbot changed the title Update debug.rst [DependencyInjection] Update debug.rst Sep 22, 2021
@aliz71
Copy link
Contributor Author

aliz71 commented Sep 22, 2021 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants