Added specification to Class Constraint Validator #1583
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi Andrea! This is a great addition to this entry. I've patched your commit into the 2.0 branch at sha: 9a08efe since the change applies to both 2.0 and master. Thanks! |
|
Hi Ryan, i'm very happy you like my little work but my commit doesn't appear in file. |
|
Hi Andrea! Your work appears in a different sha, at sha: 9a08efe. The reason is that your fix applies to both the master branch at 2.0 branch, and in this case, the commit must be made to the 2.0 branch (and then later we merge 2.0 into master). Since the PR was against the master branch, I patched in your commit. So, your work has a different commit hash, but you still properly get the credit :) Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.