[Standards] Improve code standards about exception and error messages #18134
+6
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
94noni
reviewed
Mar 28, 2023
| technical element (such as a method name for example). Double quotes must be used | ||
| at all time; | ||
|
|
||
| * Exception and error messages must start with a capital letter and finish with a dot ``.``; |
There was a problem hiding this comment.
should this also be defined for deprecation messages?
94noni
approved these changes
Mar 28, 2023
|
Thanks Alex! While merging, I did some minor tweak to add an example (336996e4481ce49c5b529c5b708b5cbc444bb750). I hope the backtick escaping works as intended. We'll see when the docs are regenerated in a few hours. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After this one being merged symfony/symfony#49829, I think the coding standards about exception can be improved a bit 👍