Fix $tags type #18647
Merged
Fix $tags type #18647
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 I think we need the same fix line 20. |
|
Exactly! |
OskarStark
reviewed
Jul 31, 2023
| @@ -17,7 +17,7 @@ Let's start by creating a ``Task`` entity:: | |||
| class Task | |||
| { | |||
| protected string $description; | |||
| protected ArrayCollection $tags; | |||
| protected Collection $tags; | |||
There was a problem hiding this comment.
ArrayCollection use statement can be removed
There was a problem hiding this comment.
I did this while merging. Thanks.
* 5.4: Backport a fix related to Webpack Encore
javiereguiluz
force-pushed
the
form_collections_tags_variable_type
branch
from
4bc4f80 to
88655a9
Compare
|
@devojifr thanks a lot for improving this ... and congrats on your first Symfony Docs contribution 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
$tags using in the documentation must be a Collection to be persisted.